From: Oleksij Rempel <o.rempel@pengutronix.de>
To: DENG Qingfang <dqfext@gmail.com>
Cc: Oleksij Rempel <linux@rempel-privat.de>,
Chris Snook <chris.snook@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Rosen Penev <rosenp@gmail.com>
Subject: Re: [PATCH net] net: ag71xx: remove unnecessary MTU reservation
Date: Thu, 18 Feb 2021 06:28:15 +0100 [thread overview]
Message-ID: <20210218052815.buawrjs4tti5e6m5@pengutronix.de> (raw)
In-Reply-To: <20210218034514.3421-1-dqfext@gmail.com>
On Thu, Feb 18, 2021 at 11:45:14AM +0800, DENG Qingfang wrote:
> 2 bytes of the MTU are reserved for Atheros DSA tag, but DSA core
> has already handled that since commit dc0fe7d47f9f.
> Remove the unnecessary reservation.
>
> Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Thank you!
> ---
> drivers/net/ethernet/atheros/ag71xx.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c
> index dd5c8a9038bb..a60ce9030581 100644
> --- a/drivers/net/ethernet/atheros/ag71xx.c
> +++ b/drivers/net/ethernet/atheros/ag71xx.c
> @@ -223,8 +223,6 @@
> #define AG71XX_REG_RX_SM 0x01b0
> #define AG71XX_REG_TX_SM 0x01b4
>
> -#define ETH_SWITCH_HEADER_LEN 2
> -
> #define AG71XX_DEFAULT_MSG_ENABLE \
> (NETIF_MSG_DRV \
> | NETIF_MSG_PROBE \
> @@ -933,7 +931,7 @@ static void ag71xx_hw_setup(struct ag71xx *ag)
>
> static unsigned int ag71xx_max_frame_len(unsigned int mtu)
> {
> - return ETH_SWITCH_HEADER_LEN + ETH_HLEN + VLAN_HLEN + mtu + ETH_FCS_LEN;
> + return ETH_HLEN + VLAN_HLEN + mtu + ETH_FCS_LEN;
> }
>
> static void ag71xx_hw_set_macaddr(struct ag71xx *ag, unsigned char *mac)
> --
> 2.25.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2021-02-18 5:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 3:45 DENG Qingfang
2021-02-18 5:28 ` Oleksij Rempel [this message]
2021-02-23 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218052815.buawrjs4tti5e6m5@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rempel-privat.de \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®