From: Pritthijit Nath <pritthijit.nath@icloud.com>
To: nsaenzjulienne@suse.de, arnd@arndb.de, dan.carpenter@oracle.com,
amarjargal16@gmail.com, phil@raspberrypi.com,
gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Pritthijit Nath <pritthijit.nath@icloud.com>
Subject: [PATCH] staging: vc04_services: Fixed address type mismatch in vchiq_arm.c
Date: Thu, 18 Feb 2021 14:40:15 +0530 [thread overview]
Message-ID: <20210218091015.92467-1-pritthijit.nath@icloud.com> (raw)
This change fixes a sparse address type mismatch warning "incorrect type
in assignment (different address spaces)".
Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index 59e45dc03a97..3c715b926a57 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -1214,11 +1214,7 @@ static int vchiq_ioc_await_completion(struct vchiq_instance *instance,
!instance->use_close_delivered)
unlock_service(service);
- /*
- * FIXME: address space mismatch, does bulk_userdata
- * actually point to user or kernel memory?
- */
- user_completion.bulk_userdata = completion->bulk_userdata;
+ user_completion.bulk_userdata = (void __user *)completion->bulk_userdata;
if (vchiq_put_completion(args->buf, &user_completion, ret)) {
if (ret == 0)
--
2.25.1
next reply other threads:[~2021-02-18 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 9:10 Pritthijit Nath [this message]
2021-02-18 9:39 ` Greg KH
2021-02-18 17:10 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218091015.92467-1-pritthijit.nath@icloud.com \
--to=pritthijit.nath@icloud.com \
--cc=amarjargal16@gmail.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=phil@raspberrypi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®