From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED7AAC432C3 for ; Thu, 18 Feb 2021 10:50:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B819064E2F for ; Thu, 18 Feb 2021 10:50:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233006AbhBRKrV (ORCPT ); Thu, 18 Feb 2021 05:47:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232126AbhBRJds (ORCPT ); Thu, 18 Feb 2021 04:33:48 -0500 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1659C06178C for ; Thu, 18 Feb 2021 01:33:07 -0800 (PST) Received: by mail-pf1-x433.google.com with SMTP id m6so922308pfk.1 for ; Thu, 18 Feb 2021 01:33:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=y5EFtSLD4pZwQqPui08w/f2nE8Hwd/5PWKGDMrasgPw=; b=ub6w3IbLaHAJBI8T1/E7fc+lPKRpfl2lCVPqMHjAO91msiqm4Lgx0xCmnaD3GDJDTt TzNiCxHc3exT3ESMIdBvSF1OX+RSV0YxVoSw1bz3BPaBOKFz/USzcqHuKgejPxAuFIbf 8cv0ZIt+YaGr5pNGksGFPAL0bjfXVRcU26b8Je/4Se95WXnLj2RTRYjFdWYWzw8plKCD z5HR+0gTWVmlgDLRZzq2z2D0f9jubn13lunrGNof8p8e5GFM/nM+2lAZpSLhujLzMihI cMPJfZKO3GWu31Ctr5b2JJaYD9bDM5p8DzdzLOJLm1ZfLZq5NrfF3R/5H40g7G7Ph1fw EpXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=y5EFtSLD4pZwQqPui08w/f2nE8Hwd/5PWKGDMrasgPw=; b=BxHXP6TyAHMj+1OyYt431dzrwfCGZ4JQI33tS35b1/iWoquDrcJkJ1UEJzVRPwL10R 34VFY7+IxTAspVqYEefS3hkKr3ldmS1ZxYjzm1eyMcrdkEWfngOdy6PDUVOsn4XPKFED aE8l0OnAIkcaY+Tf9Fjmtr7vidPuI3t3tsHjcyQz4DK8QhGiUSIYY85w9PqjGUN9YOfp KXK15Mtl9/DobHLFXFXm55wUad2Ms5C3pqmKIujripW98aWFSPFknYxZaWto2CAA8PCh RLHKhCsJ3sctuqAasio9ygwX5gdZPb6Nnug3jv1igS5VD7Cxu9CJ3pskKQpMzWfkjYpz mbUw== X-Gm-Message-State: AOAM531YfrrVcyGAsMxnqdE5PjselN5QOQjNuHgELmLmMq1i4aGyR9Wa 6ItCg6f1qE9dTLO9cRzW4NZPrA== X-Google-Smtp-Source: ABdhPJzmWDkUF+XEu/Fd7S8XY6GJ1/Rv+yNGyliwnb2m8eSYg//p5LFdVT71/My0rSPWXYmE0uBSaA== X-Received: by 2002:a63:2b82:: with SMTP id r124mr3295183pgr.310.1613640787362; Thu, 18 Feb 2021 01:33:07 -0800 (PST) Received: from localhost ([122.172.59.240]) by smtp.gmail.com with ESMTPSA id s11sm5145642pfu.69.2021.02.18.01.33.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Feb 2021 01:33:06 -0800 (PST) Date: Thu, 18 Feb 2021 15:03:04 +0530 From: Viresh Kumar To: Ionela Voinescu Cc: Rafael Wysocki , Catalin Marinas , Will Deacon , Vincent Guittot , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Sudeep Holla , Greg Kroah-Hartman Subject: Re: [PATCH V3 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback Message-ID: <20210218093304.3mt3o7kbeymn5ofl@vireshk-i7> References: <20210203114521.GA6380@arm.com> <20210205091424.3od3tme3f7mh7ebp@vireshk-i7> <20210217002422.GA17422@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210217002422.GA17422@arm.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17-02-21, 00:24, Ionela Voinescu wrote: > > diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c > > index 1e47dfd465f8..47fca7376c93 100644 > > --- a/arch/arm64/kernel/topology.c > > +++ b/arch/arm64/kernel/topology.c > > @@ -240,7 +240,6 @@ static struct scale_freq_data amu_sfd = { > > > > static void amu_fie_setup(const struct cpumask *cpus) > > { > > - bool invariant; > > int cpu; > > > > /* We are already set since the last insmod of cpufreq driver */ > > @@ -257,25 +256,10 @@ static void amu_fie_setup(const struct cpumask *cpus) > > > > cpumask_or(amu_fie_cpus, amu_fie_cpus, cpus); > > > > - invariant = topology_scale_freq_invariant(); > > - > > - /* We aren't fully invariant yet */ > > - if (!invariant && !cpumask_equal(amu_fie_cpus, cpu_present_mask)) > > - return; > > - > > You still need these checks, otherwise you could end up with only part > of the CPUs setting a scale factor, when only part of the CPUs support > AMUs and there is no cpufreq support for FIE. Another look at it and here goes another reason (hope I don't have another in-code comment somewhere else to kill this one) :) We don't need to care for the reason you gave (which is a valid reason otherwise), as we are talking specifically about amu_fie_setup() here and it gets called from cpufreq policy-notifier. i.e. we won't support AMUs without cpufreq being there in the first place and the same goes for cppc-driver. Does that sound reasonable ? -- viresh