From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6100C433E0 for ; Fri, 19 Feb 2021 06:58:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D8CA64EC4 for ; Fri, 19 Feb 2021 06:58:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229720AbhBSG6g (ORCPT ); Fri, 19 Feb 2021 01:58:36 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:50720 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbhBSG6Z (ORCPT ); Fri, 19 Feb 2021 01:58:25 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11J6sQn9002518; Fri, 19 Feb 2021 06:57:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=OuWv1NOCvL6KLKV8PTGUfvktlcxHtE9DUHDQ4QTOEpk=; b=CRaLHCbNxmB1mN2SSQAVpZB8SELkmHkqytgwqC4Da6l4MU08h6zKlCqYtGVjSGbunhZ+ PdGHToGWlxpmkXuEAXgZQlTlT04pa4W6W5eDWa4BakLBsgy4xKSiN2o++kWvVDC2pYy5 jdrALpzBqIX+M3JUwO2NLyXh+v3TMOGXLOEKDn12VVdubrhvfGNB8Fa4211xJcg/Cvnv KFuZRPdIvG5oROngufLrHjzhvJBhFJDbWEYnuH+dERtXOOLYA4Fl7unOt2S1s86cZI7c Y6OyA7exCXcCEqCvALJuYKqlU+pNeaGQpcQSadwSlf/se/ZGaGl41ltrgAVHAuryqqvY lQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2130.oracle.com with ESMTP id 36p49bgkxk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Feb 2021 06:57:32 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11J6uUMr112833; Fri, 19 Feb 2021 06:57:31 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 36prbrswnp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Feb 2021 06:57:31 +0000 Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 11J6vQ9j003078; Fri, 19 Feb 2021 06:57:26 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 19 Feb 2021 06:57:25 +0000 Date: Fri, 19 Feb 2021 09:57:17 +0300 From: Dan Carpenter To: Kurt Manucredo Cc: gregkh@linuxfoundation.org, ross.schm.dev@gmail.com, straube.linux@gmail.com, d.straghkov@ispras.ru, tiwai@suse.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: rtl8723bs: code-style fix Message-ID: <20210219065717.GO2222@kadam> References: <20210218163204.7-1-fuzzybritches@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210218163204.7-1-fuzzybritches@protonmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-IMR: 1 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9899 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 mlxscore=0 phishscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102190050 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9899 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 phishscore=0 clxscore=1011 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102190050 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The subject is too vague. On Thu, Feb 18, 2021 at 04:33:10PM +0000, Kurt Manucredo wrote: > Signed-off-by: Kurt Manucredo > --- > > Checkpatch complains the constant needs to be on the right side of the > comparison. The preferred way is: > The commit message isn't complete and it has to go above the Signed-off-by line. regards, dan carpenter