From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05CA0C433E0 for ; Fri, 19 Feb 2021 09:47:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF1E164E28 for ; Fri, 19 Feb 2021 09:47:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229952AbhBSJrN (ORCPT ); Fri, 19 Feb 2021 04:47:13 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:42006 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbhBSJrE (ORCPT ); Fri, 19 Feb 2021 04:47:04 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 8F9D81C0B80; Fri, 19 Feb 2021 10:46:21 +0100 (CET) Date: Fri, 19 Feb 2021 10:46:21 +0100 From: Pavel Machek To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-leds@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 1/2] leds: trigger: Fix error path to not unlock the unlocked mutex Message-ID: <20210219094621.GA5641@duo.ucw.cz> References: <20210219082955.5007-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU" Content-Disposition: inline In-Reply-To: <20210219082955.5007-1-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2021-02-19 09:29:54, Uwe Kleine-K=F6nig wrote: > ttyname is allocated before the mutex is taken, so it must not be > unlocked in the error path. >=20 Acked-by: Pavel Machek --=20 http://www.livejournal.com/~pavelmachek --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYC+I7QAKCRAw5/Bqldv6 8lDQAKC6RnFOnSLK4XZFGvrX+5EyTcu6fgCgnQ2bPOWU4CI+59NCUW4TYIdtKpU= =TZpc -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU--