From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87A68C433DB for ; Fri, 19 Feb 2021 11:18:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 367F864EC0 for ; Fri, 19 Feb 2021 11:18:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230145AbhBSLSI (ORCPT ); Fri, 19 Feb 2021 06:18:08 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:49270 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230071AbhBSLR5 (ORCPT ); Fri, 19 Feb 2021 06:17:57 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 927501C0B80; Fri, 19 Feb 2021 12:16:59 +0100 (CET) Date: Fri, 19 Feb 2021 12:16:59 +0100 From: Pavel Machek To: Sven Schuchmann Cc: Dan Murphy , "linux-leds@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT Message-ID: <20210219111659.GI19207@duo.ucw.cz> References: <20210204143738.28036-1-schuchmann@schleissheimer.de> <20210204145308.GC14305@duo.ucw.cz> <20210205103438.GB27854@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="poJSiGMzRSvrLGLs" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --poJSiGMzRSvrLGLs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > > ? Does not make sense and changelog does not help. > > > > > > This is an unused variable which is in the driver > > > (same as the regulator). Should I provide a patch on its own for that > > > or just describe in the changelog? > >=20 > > Lets do separate patch here. DT changes will need Ack from Rob, this > > can go in directly. >=20 > Okay, I will submit a separate patch >=20 > > Can you or Dan submit patch getting the regulator support to work? If > > not, I guess we should remove the regulator support after all. >=20 > To be true I am fairly new to the kernel and have no idea > how to test this. So no, I don't want provide a patch (except > for removing), sorry. No problem. It seems Andy submitted series for this. Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --poJSiGMzRSvrLGLs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYC+eKwAKCRAw5/Bqldv6 8k0GAJ9eBnOqKXpNbD64WsGkaDn2QJtn9QCfZh77uCdQ3ZmsZvhJHWa9JpKOqrg= =ztOQ -----END PGP SIGNATURE----- --poJSiGMzRSvrLGLs--