From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4823DC433DB for ; Sat, 20 Feb 2021 09:51:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3BB964ED2 for ; Sat, 20 Feb 2021 09:51:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229806AbhBTJtl (ORCPT ); Sat, 20 Feb 2021 04:49:41 -0500 Received: from mga05.intel.com ([192.55.52.43]:40939 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229476AbhBTJt0 (ORCPT ); Sat, 20 Feb 2021 04:49:26 -0500 IronPort-SDR: lFj1AzefuRA5ACqTegbYsNQqx8EwJlr+RDD2JB3lQLLmBF8M/F9/XMqEWqUSjOPh6qzhgSMDbt OpKzNW92946g== X-IronPort-AV: E=McAfee;i="6000,8403,9900"; a="268940687" X-IronPort-AV: E=Sophos;i="5.81,192,1610438400"; d="scan'208";a="268940687" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2021 01:48:45 -0800 IronPort-SDR: 9adtJopHLObI4Buw1EoCxcKSFXrM6VkDSAQxB4py9rQVCnGk4bB+hKlo2vcqMwfKTEZH4ybIjp cRDL7Ap/sFWA== X-IronPort-AV: E=Sophos;i="5.81,192,1610438400"; d="scan'208";a="387633482" Received: from shuo-intel.sh.intel.com (HELO localhost) ([10.239.154.30]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2021 01:48:44 -0800 Date: Sat, 20 Feb 2021 17:48:42 +0800 From: Shuo A Liu To: Yejune Deng Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] virt: acrn: Use vfs_poll() instead of f_op->poll() Message-ID: <20210220094842.GB30008@shuo-intel.sh.intel.com> References: <20210219092612.7533-1-yejune.deng@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210219092612.7533-1-yejune.deng@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for the patch. On Fri 19.Feb'21 at 17:26:12 +0800, Yejune Deng wrote: >In acrn_irqfd_assign(), use vfs_poll() is a more advanced function, >as the same time, modify the definition of events. > >Signed-off-by: Yejune Deng >--- > drivers/virt/acrn/irqfd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/virt/acrn/irqfd.c b/drivers/virt/acrn/irqfd.c >index a8766d528e29..19890396e174 100644 >--- a/drivers/virt/acrn/irqfd.c >+++ b/drivers/virt/acrn/irqfd.c >@@ -112,9 +112,9 @@ static int acrn_irqfd_assign(struct acrn_vm *vm, struct acrn_irqfd *args) > { > struct eventfd_ctx *eventfd = NULL; > struct hsm_irqfd *irqfd, *tmp; >- unsigned int events; > struct fd f; > int ret = 0; >+ __poll_t events; Can you keep variable declarations is reverse fir tree order which this driver follows? > > irqfd = kzalloc(sizeof(*irqfd), GFP_KERNEL); > if (!irqfd) >@@ -158,7 +158,7 @@ static int acrn_irqfd_assign(struct acrn_vm *vm, struct acrn_irqfd *args) > mutex_unlock(&vm->irqfds_lock); > > /* Check the pending event in this stage */ >- events = f.file->f_op->poll(f.file, &irqfd->pt); >+ events = vfs_poll(f.file, &irqfd->pt); > > if (events & POLLIN) > acrn_irqfd_inject(irqfd); >-- >2.29.0 >