mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Johannes Berg <johannes.berg@intel.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Richard Weinberger <richard@nod.at>
Subject: arch/x86/um/shared/sysdep/stub_32.h:80:1: warning: 'inline' is not at beginning of declaration
Date: Mon, 22 Feb 2021 15:19:38 +0800	[thread overview]
Message-ID: <202102221535.cIzMH0pU-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2903 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   31caf8b2a847214be856f843e251fc2ed2cd1075
commit: 9f0b4807a44ff81cf59421c8a86641efec586610 um: rework userspace stubs to not hard-code stub location
date:   9 days ago
config: um-i386_defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9f0b4807a44ff81cf59421c8a86641efec586610
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 9f0b4807a44ff81cf59421c8a86641efec586610
        # save the attached .config to linux build tree
        make W=1 ARCH=um SUBARCH=i386

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from arch/x86/um/shared/sysdep/stub.h:9,
                    from arch/um/kernel/skas/clone.c:14:
>> arch/x86/um/shared/sysdep/stub_32.h:80:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
      80 | static void inline remap_stack_and_trap(void)
         | ^~~~~~
--
   In file included from arch/x86/um/shared/sysdep/stub.h:9,
                    from arch/um/os-Linux/skas/process.c:23:
>> arch/x86/um/shared/sysdep/stub_32.h:80:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
      80 | static void inline remap_stack_and_trap(void)
         | ^~~~~~
   arch/um/os-Linux/skas/process.c:106:6: warning: no previous prototype for 'wait_stub_done' [-Wmissing-prototypes]
     106 | void wait_stub_done(int pid)
         |      ^~~~~~~~~~~~~~
   arch/um/os-Linux/skas/process.c:720:6: warning: no previous prototype for '__switch_mm' [-Wmissing-prototypes]
     720 | void __switch_mm(struct mm_id *mm_idp)
         |      ^~~~~~~~~~~


vim +/inline +80 arch/x86/um/shared/sysdep/stub_32.h

    79	
  > 80	static void inline remap_stack_and_trap(void)
    81	{
    82		__asm__ volatile (
    83			"movl %%esp,%%ebx ;"
    84			"andl %0,%%ebx ;"
    85			"movl %1,%%eax ;"
    86			"movl %%ebx,%%edi ; addl %2,%%edi ; movl (%%edi),%%edi ;"
    87			"movl %%ebx,%%ebp ; addl %3,%%ebp ; movl (%%ebp),%%ebp ;"
    88			"int $0x80 ;"
    89			"addl %4,%%ebx ; movl %%eax, (%%ebx) ;"
    90			"int $3"
    91			: :
    92			"g" (~(UM_KERN_PAGE_SIZE - 1)),
    93			"g" (STUB_MMAP_NR),
    94			"g" (UML_STUB_FIELD_FD),
    95			"g" (UML_STUB_FIELD_OFFSET),
    96			"g" (UML_STUB_FIELD_CHILD_ERR),
    97			"c" (UM_KERN_PAGE_SIZE),
    98			"d" (PROT_READ | PROT_WRITE),
    99			"S" (MAP_FIXED | MAP_SHARED)
   100			:
   101			"memory");
   102	}
   103	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 8759 bytes --]

                 reply	other threads:[~2021-02-22  7:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202102221535.cIzMH0pU-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=johannes.berg@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®