From: Julian Braha <julianbraha@gmail.com>
To: perex@perex.cz
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH] sound: soc: codecs: fix kconfig dependency on GPIOLIB
Date: Mon, 22 Feb 2021 16:44:44 -0500 [thread overview]
Message-ID: <20210222214444.23340-1-julianbraha@gmail.com> (raw)
When SND_SOC_DMIC is enabled and GPIOLIB is disabled,
Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for SND_SOC_DMIC
Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
Selected by [y]:
- SND_SOC_AMD_RENOIR_MACH [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_AMD_RENOIR [=y]
This is because SND_SOC_AMD_RENOIR_MACH selects SND_SOC_DMIC,
without depending on or selecting GPIOLIB, despite that config option
depending on GPIOLIB.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
sound/soc/amd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index a6ce000fac3f..5480dff7a1ad 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -46,6 +46,7 @@ config SND_SOC_AMD_RENOIR
config SND_SOC_AMD_RENOIR_MACH
tristate "AMD Renoir support for DMIC"
+ select GPIOLIB
select SND_SOC_DMIC
depends on SND_SOC_AMD_RENOIR
help
--
2.27.0
reply other threads:[~2021-02-22 21:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222214444.23340-1-julianbraha@gmail.com \
--to=julianbraha@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®