From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 999F2C433DB for ; Mon, 22 Feb 2021 22:06:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34D9764DA8 for ; Mon, 22 Feb 2021 22:06:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230450AbhBVWGA (ORCPT ); Mon, 22 Feb 2021 17:06:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:42454 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229967AbhBVWFy (ORCPT ); Mon, 22 Feb 2021 17:05:54 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id B010964DA8; Mon, 22 Feb 2021 22:05:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614031513; bh=3DBporj5bgL5GQOIf53BNFynYl1VAF4WTalHirbOcnw=; h=From:To:Cc:Subject:Date:From; b=XPwiQ7z35DRTOPAYen015g4tgDNdsMj7fzMJnA9MQ5UGmziKvrQqX1CQxMj3hiQbB 50PchCdgzb0xR/lNL7k9jdXgxnPXr3rN8HsRBSLtChMBcPug3qX8ig2ENtD0dsmo7z 4NdzUm4zLwSO0Y2hIEwYYDWNyRbzS3fVZAwmBIVi8K04W852DoAA2pwrZ3doLqtndw rVqiDFDEIOcBxAo+U1cOScF2sxtoWtpX+dFPdpNPfRYFZ1Sx989DDeiYFNzpgUEVzx TXOvuxrCVlJrOICl9Z6JHvAMGx0wY8MKTkbQGNKyQn/+yzo0BSWgz5fK0/elo3f2yk p32PlYBwaoBsw== From: Oded Gabbay To: linux-kernel@vger.kernel.org Cc: Tomer Tayar Subject: [PATCH 1/2] habanalabs: Call put_pid() when releasing control device Date: Tue, 23 Feb 2021 00:05:07 +0200 Message-Id: <20210222220508.4659-1-ogabbay@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tomer Tayar The refcount of the "hl_fpriv" structure is not used for the control device, and thus hl_hpriv_put() is not called when releasing this device. This results with no call to put_pid(), so add it explicitly in hl_device_release_ctrl(). Signed-off-by: Tomer Tayar Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/misc/habanalabs/common/device.c b/drivers/misc/habanalabs/common/device.c index 15fcb5c31c4b..9ecd805f0e88 100644 --- a/drivers/misc/habanalabs/common/device.c +++ b/drivers/misc/habanalabs/common/device.c @@ -117,6 +117,8 @@ static int hl_device_release_ctrl(struct inode *inode, struct file *filp) list_del(&hpriv->dev_node); mutex_unlock(&hdev->fpriv_list_lock); + put_pid(hpriv->taskpid); + kfree(hpriv); return 0; -- 2.25.1