From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BA4CC433DB for ; Tue, 23 Feb 2021 14:20:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C581364DE7 for ; Tue, 23 Feb 2021 14:20:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232993AbhBWOUV (ORCPT ); Tue, 23 Feb 2021 09:20:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:47786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232326AbhBWOUS (ORCPT ); Tue, 23 Feb 2021 09:20:18 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 103EE64E58; Tue, 23 Feb 2021 14:19:37 +0000 (UTC) Date: Tue, 23 Feb 2021 09:19:36 -0500 From: Steven Rostedt To: Jens Wiklander Cc: Jisheng Zhang , Linux Kernel Mailing List , op-tee@lists.trustedfirmware.org, Linux ARM Subject: Re: [PATCH] tee: optee: add invoke_fn tracepoints Message-ID: <20210223091936.5b390f35@gandalf.local.home> In-Reply-To: <20210223131124.GA2303918@jade> References: <20210210144409.36ecdaed@xhacker.debian> <20210223184026.22c86356@xhacker.debian> <20210223131124.GA2303918@jade> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 Feb 2021 14:11:24 +0100 Jens Wiklander wrote: > I used the -strict option. > > ./scripts/checkpatch.pl -strict 0001-tee-optee-add-invoke_fn-tracepoints.patch > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #44: > new file mode 100644 The above is just asking for someone to take maintainership of the new file. > > CHECK: Alignment should match open parenthesis > #68: FILE: drivers/tee/optee/optee_trace.h:20: > +TRACE_EVENT(optee_invoke_fn_begin, > + TP_PROTO(struct optee_rpc_param *param), > > CHECK: Lines should not end with a '(' > #71: FILE: drivers/tee/optee/optee_trace.h:23: > + TP_STRUCT__entry( > > CHECK: Lines should not end with a '(' > #76: FILE: drivers/tee/optee/optee_trace.h:28: > + TP_fast_assign( > > CHECK: Alignment should match open parenthesis > #89: FILE: drivers/tee/optee/optee_trace.h:41: > +TRACE_EVENT(optee_invoke_fn_end, > + TP_PROTO(struct optee_rpc_param *param, struct arm_smccc_res *res), > > CHECK: Lines should not end with a '(' > #92: FILE: drivers/tee/optee/optee_trace.h:44: > + TP_STRUCT__entry( > > CHECK: Lines should not end with a '(' > #97: FILE: drivers/tee/optee/optee_trace.h:49: > + TP_fast_assign( The TRACE_EVENT() macro is "special", and checkpatch notoriously stumbles over it. I usually recommend that people ignore the checkpatch warnings on TRACE_EVENT() macros. -- Steve > > total: 0 errors, 1 warnings, 6 checks, 86 lines checked