From: "Paul E. McKenney" <paulmck@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: josh@joshtriplett.org, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
joel@joelfernandes.org, rcu@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: make nocb_nobypass_lim_per_jiffy static
Date: Wed, 24 Feb 2021 16:44:30 -0800 [thread overview]
Message-ID: <20210225004430.GA9420@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <1614155429-64546-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On Wed, Feb 24, 2021 at 04:30:29PM +0800, Jiapeng Chong wrote:
> Fix the following sparse warning:
>
> kernel/rcu/tree_plugin.h:1497:5: warning: symbol
> 'nocb_nobypass_lim_per_jiffy' was not declared. Should it be static?
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Queued with Frederic's ack (given offlist), thank you both!
Thanx, Paul
> ---
> kernel/rcu/tree_plugin.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> index 2d60377..8ff8cf8 100644
> --- a/kernel/rcu/tree_plugin.h
> +++ b/kernel/rcu/tree_plugin.h
> @@ -1494,7 +1494,7 @@ static int __init parse_rcu_nocb_poll(char *arg)
> * After all, the main point of bypassing is to avoid lock contention
> * on ->nocb_lock, which only can happen at high call_rcu() rates.
> */
> -int nocb_nobypass_lim_per_jiffy = 16 * 1000 / HZ;
> +static int nocb_nobypass_lim_per_jiffy = 16 * 1000 / HZ;
> module_param(nocb_nobypass_lim_per_jiffy, int, 0);
>
> /*
> --
> 1.8.3.1
>
prev parent reply other threads:[~2021-02-25 0:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 8:30 Jiapeng Chong
2021-02-25 0:44 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210225004430.GA9420@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®