mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Dario Binacchi <dariobin@libero.it>
Cc: linux-kernel@vger.kernel.org,
	Alexander Stein <alexander.stein@systec-electronic.com>,
	Federico Vaga <federico.vaga@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Oliver Hartkopp <socketcan@hartkopp.net>,
	Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
	Wolfgang Grandegger <wg@grandegger.com>,
	YueHaibing <yuehaibing@huawei.com>,
	Zhang Qilong <zhangqilong3@huawei.com>,
	linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 6/6] can: c_can: add support to 64 message objects
Date: Fri, 26 Feb 2021 09:43:59 +0100	[thread overview]
Message-ID: <20210226084359.jnlq6ccbeuib6zis@pengutronix.de> (raw)
In-Reply-To: <20210225215155.30509-7-dariobin@libero.it>

[-- Attachment #1: Type: text/plain, Size: 1812 bytes --]

On 25.02.2021 22:51:55, Dario Binacchi wrote:
> --- a/drivers/net/can/c_can/c_can.h
> +++ b/drivers/net/can/c_can/c_can.h
> @@ -22,8 +22,6 @@
>  #ifndef C_CAN_H
>  #define C_CAN_H
>  
> -#define C_CAN_NO_OF_OBJECTS	32
> -
>  enum reg {
>  	C_CAN_CTRL_REG = 0,
>  	C_CAN_CTRL_EX_REG,
> @@ -61,6 +59,7 @@ enum reg {
>  	C_CAN_NEWDAT2_REG,
>  	C_CAN_INTPND1_REG,
>  	C_CAN_INTPND2_REG,
> +	C_CAN_INTPND3_REG,
>  	C_CAN_MSGVAL1_REG,
>  	C_CAN_MSGVAL2_REG,
>  	C_CAN_FUNCTION_REG,
> @@ -122,6 +121,7 @@ static const u16 __maybe_unused reg_map_d_can[] = {
>  	[C_CAN_NEWDAT2_REG]	= 0x9E,
>  	[C_CAN_INTPND1_REG]	= 0xB0,
>  	[C_CAN_INTPND2_REG]	= 0xB2,
> +	[C_CAN_INTPND3_REG]	= 0xB4,
>  	[C_CAN_MSGVAL1_REG]	= 0xC4,
>  	[C_CAN_MSGVAL2_REG]	= 0xC6,
>  	[C_CAN_IF1_COMREQ_REG]	= 0x100,
> @@ -161,6 +161,7 @@ struct raminit_bits {
>  
>  struct c_can_driver_data {
>  	enum c_can_dev_id id;
> +	int msg_obj_num;

unsigned int

>  
>  	/* RAMINIT register description. Optional. */
>  	const struct raminit_bits *raminit_bits; /* Array of START/DONE bit positions */
> diff --git a/drivers/net/can/c_can/c_can_pci.c b/drivers/net/can/c_can/c_can_pci.c
> index 3752f68d095e..2cb98ccd04d7 100644
> --- a/drivers/net/can/c_can/c_can_pci.c
> +++ b/drivers/net/can/c_can/c_can_pci.c
> @@ -31,6 +31,8 @@ enum c_can_pci_reg_align {
>  struct c_can_pci_data {
>  	/* Specify if is C_CAN or D_CAN */
>  	enum c_can_dev_id type;
> +	/* Number of message objects */
> +	int msg_obj_num;

unsigned int


Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2021-02-26  8:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 21:51 [PATCH v2 0/6] " Dario Binacchi
2021-02-25 21:51 ` [PATCH v2 1/6] can: c_can: remove unused code Dario Binacchi
2021-02-25 21:51 ` [PATCH v2 2/6] can: c_can: fix indentation Dario Binacchi
2021-02-25 21:51 ` [PATCH v2 3/6] can: c_can: fix control interface used by c_can_do_tx Dario Binacchi
2021-02-26  8:44   ` Marc Kleine-Budde
2021-02-28 10:35     ` Dario Binacchi
2021-03-01 11:36       ` Marc Kleine-Budde
2021-03-01 17:38         ` Dario Binacchi
2021-02-25 21:51 ` [PATCH v2 4/6] can: c_can: use 32-bit write to set arbitration register Dario Binacchi
2021-02-25 21:51 ` [PATCH v2 5/6] can: c_can: prepare to up the message objects number Dario Binacchi
2021-02-26  8:33   ` Marc Kleine-Budde
2021-02-28 10:18     ` Dario Binacchi
2021-03-01 11:51       ` Marc Kleine-Budde
2021-02-26  9:21   ` Marc Kleine-Budde
2021-02-25 21:51 ` [PATCH v2 6/6] can: c_can: add support to 64 message objects Dario Binacchi
2021-02-26  8:43   ` Marc Kleine-Budde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210226084359.jnlq6ccbeuib6zis@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=alexander.stein@systec-electronic.com \
    --cc=dariobin@libero.it \
    --cc=davem@davemloft.net \
    --cc=federico.vaga@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mailhol.vincent@wanadoo.fr \
    --cc=netdev@vger.kernel.org \
    --cc=socketcan@hartkopp.net \
    --cc=wg@grandegger.com \
    --cc=yuehaibing@huawei.com \
    --cc=zhangqilong3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®