From: Richard Cochran <richardcochran@gmail.com>
To: Heiko Thiery <heiko.thiery@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Fugang Duan <fugang.duan@nxp.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled
Date: Fri, 26 Feb 2021 07:23:31 -0800 [thread overview]
Message-ID: <20210226152331.GD26140@hoboy.vegasvil.org> (raw)
In-Reply-To: <20210225211514.9115-1-heiko.thiery@gmail.com>
On Thu, Feb 25, 2021 at 10:15:16PM +0100, Heiko Thiery wrote:
> When accessing the timecounter register on an i.MX8MQ the kernel hangs.
> This is only the case when the interface is down. This can be reproduced
> by reading with 'phc_ctrl eth0 get'.
>
> Like described in the change in 91c0d987a9788dcc5fe26baafd73bf9242b68900
> the igp clock is disabled when the interface is down and leads to a
> system hang.
>
> So we check if the ptp clock status before reading the timecounter
> register.
>
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
> v2:
> - add mutex (thanks to Richard)
>
> v3:
> I did a mistake and did not test properly
> - add parenteses
> - fix the used variable
Acked-by: Richard Cochran <richardcochran@gmail.com>
next prev parent reply other threads:[~2021-02-26 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 21:15 Heiko Thiery
2021-02-26 7:22 ` Heiko Thiery
2021-02-26 15:23 ` Richard Cochran [this message]
2021-02-26 23:44 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2021-02-25 20:55 Heiko Thiery
2021-02-25 22:34 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210226152331.GD26140@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=fugang.duan@nxp.com \
--cc=heiko.thiery@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®