From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2EC4C433E0 for ; Mon, 1 Mar 2021 08:37:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E1F864DDE for ; Mon, 1 Mar 2021 08:37:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233243AbhCAIgm (ORCPT ); Mon, 1 Mar 2021 03:36:42 -0500 Received: from mga05.intel.com ([192.55.52.43]:57185 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233110AbhCAIfN (ORCPT ); Mon, 1 Mar 2021 03:35:13 -0500 IronPort-SDR: 1er/7xRjkrEnUDQQiHHKvNBI3cS0DgoTKD54XCl3PzckuQ/aR1/XGgXlUyQfDnEsdUMkc8eEjl 2NkrwxeJE8Rw== X-IronPort-AV: E=McAfee;i="6000,8403,9909"; a="271393088" X-IronPort-AV: E=Sophos;i="5.81,215,1610438400"; d="scan'208";a="271393088" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2021 00:33:18 -0800 IronPort-SDR: 6BGOXUAqgvhmNQ0d5WoXKH1fHuucsPeWDsGuuDGiAro/r0Ui5Wfdhev1FTGEYN5967UVVhiIPX pQbo8oImVPRQ== X-IronPort-AV: E=Sophos;i="5.81,215,1610438400"; d="scan'208";a="366632610" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2021 00:33:12 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 3C2DF202DD; Mon, 1 Mar 2021 10:33:08 +0200 (EET) Date: Mon, 1 Mar 2021 10:33:08 +0200 From: Sakari Ailus To: Laurent Pinchart Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Laurent Pinchart , mchehab@kernel.org, hverkuil@xs4all.nl Subject: Re: [PATCH 2/2] media: v4l2-async: Safely unregister an non-registered async subdev Message-ID: <20210301083308.GS3@paasikivi.fi.intel.com> References: <20210226224938.18166-1-laurent.pinchart@ideasonboard.com> <20210226224938.18166-2-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210226224938.18166-2-laurent.pinchart@ideasonboard.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurent, On Sat, Feb 27, 2021 at 12:49:38AM +0200, Laurent Pinchart wrote: > From: Laurent Pinchart > > Make the V4L2 async framework a bit more robust by allowing to > unregister a non-registered async subdev. Otherwise the > v4l2_async_cleanup() will attempt to delete the async subdev from the > subdev_list with the corresponding list_head not initialized. > > Signed-off-by: Laurent Pinchart Acked-by: Sakari Ailus IMO this can be merged through another tree once the first patch is agreed on. Cc Hans and Mauro, too. > --- > drivers/media/v4l2-core/v4l2-async.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c > index 37cc0263b273..2347b7ac54d4 100644 > --- a/drivers/media/v4l2-core/v4l2-async.c > +++ b/drivers/media/v4l2-core/v4l2-async.c > @@ -750,6 +750,9 @@ EXPORT_SYMBOL(v4l2_async_register_subdev); > > void v4l2_async_unregister_subdev(struct v4l2_subdev *sd) > { > + if (list_is_null(&sd->async_list)) > + return; > + > mutex_lock(&list_lock); > > __v4l2_async_notifier_unregister(sd->subdev_notifier); -- Kind regards, Sakari Ailus