From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B40EC4361B for ; Tue, 2 Mar 2021 16:07:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC79D64F17 for ; Tue, 2 Mar 2021 16:07:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1449038AbhCBQDl (ORCPT ); Tue, 2 Mar 2021 11:03:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:36436 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351142AbhCBNcc (ORCPT ); Tue, 2 Mar 2021 08:32:32 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1D9CB64F12; Tue, 2 Mar 2021 13:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614691310; bh=iytCnS3/Fqm59AJCTx4Td5YHfFiyyY8XF5Iqi/De8P4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JvfE4cxhrvhQNG1uiT0poBGzhekrWpbOlIxK5VePyKISfBBW0lWl+QjPPnYMDsQxj aLVRYCTHbYDFDa2i6U5CLy2RDtw++OtYk4lMJGB3yevFI4N1u4lDm47+L3H2JvSsTe d7CIVghk8hBQXjor5pOtpUj70VWid0EEzCgnKx1sgW7t6Seh0kCpSNYNGWstspbKEg jS7hl04Q9dvcbiRQrPgAn7j1ZCP04AllSdxWPUzB2w1W3EAbHoz8BN2VGepEoV0IHj 1zFWHOJPzbnVV/lKcKtt8XuUeX/J4s21r4JRqXFQWr75enJiCzOKUdrnPgGIfUJtz0 HLYJf/BOR4FQA== Date: Tue, 2 Mar 2021 13:20:43 +0000 From: Mark Brown To: tangbin Cc: Paul Cercueil , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: codec: Omit superfluous error message injz4760_codec_probe() Message-ID: <20210302132043.GF4522@sirena.org.uk> References: <20210302121148.28328-1-tangbin@cmss.chinamobile.com> <76c87931-094e-0804-9405-ad4841fae2d3@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+jhVVhN62yS6hEJ8" Content-Disposition: inline In-Reply-To: <76c87931-094e-0804-9405-ad4841fae2d3@cmss.chinamobile.com> X-Cookie: Friction is a drag. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --+jhVVhN62yS6hEJ8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 02, 2021 at 08:55:25PM +0800, tangbin wrote: > Yes, I would have written it in your ways, but considered the variable > "ret", I gave up, and just deleted dev_err(). If it's not used any more it can just be removed. --+jhVVhN62yS6hEJ8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmA+O6sACgkQJNaLcl1U h9D3Qgf8DCZVmc6ugbe3U+nU/APz1o3uNlnfvCBUw0+J0EN+fkVj0Aoj493A0viD IuXCy7XCPmam3JE4yIYbnA/FzmIs+PJ36/CnKNOH22e63WxWd5zdFk1S4dW6LA1m 1ucckj2XD3+y6xGscd7FIdgX7EPoGYvKC2zB6QYBypL4mkNk09S7bjStYApaZKNK q+3wIjc/HoGFrKwG+L5v/wDeoMA6NX+x526O+3BDCv46JClza20O0OtHg8iSE8hL oKJxwBcluivy3SW/McFFmCIHnS8t+6B/UZ72PsSKjFkyKSqB8lgLNE5Dez/F10K8 VFuCsAchxsyOWBiVzHCjrZsDDKze1g== =uM7f -----END PGP SIGNATURE----- --+jhVVhN62yS6hEJ8--