From: Dan Carpenter <dan.carpenter@oracle.com>
To: Perrin Smith <perrinjamessmith@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
yashsri421@gmail.com, tiwai@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: remove unnecessary break
Date: Tue, 2 Mar 2021 19:24:18 +0300 [thread overview]
Message-ID: <20210302162417.GU2087@kadam> (raw)
In-Reply-To: <20210302152903.2930-1-perrinjemessmith@gmail.com>
On Tue, Mar 02, 2021 at 11:29:03PM +0800, Perrin Smith wrote:
> From: Perrin Smith <perrinjamessmith@gmail.com>
>
> removed unnecessary break at end of while loop
>
> Signed-off-by: Perrin Smith <perrinjamessmith@gmail.com>
> ---
> drivers/staging/rtl8192e/rtllib_rx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index b8ab34250e6a..2de6330b7737 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -460,8 +460,6 @@ static bool AddReorderEntry(struct rx_ts_record *pTS,
> ((struct rx_reorder_entry *)list_entry(pList->next,
> struct rx_reorder_entry, List))->SeqNum))
> return false;
> - else
> - break;
No, this break is necessary. The patch introduces a bug. You need to
be careful following checkpatch's advice because it's just a simple
Perl script.
> }
regards,
dan carpenter
prev parent reply other threads:[~2021-03-02 20:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 15:29 Perrin Smith
2021-03-02 16:24 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210302162417.GU2087@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perrinjamessmith@gmail.com \
--cc=tiwai@suse.de \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®