mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daejun Park <daejun7.park@samsung.com>
To: Bean Huo <huobean@gmail.com>,
	Daejun Park <daejun7.park@samsung.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	"avri.altman@wdc.com" <avri.altman@wdc.com>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
	"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
	"cang@codeaurora.org" <cang@codeaurora.org>,
	"bvanassche@acm.org" <bvanassche@acm.org>,
	ALIM AKHTAR <alim.akhtar@samsung.com>,
	Javier Gonzalez <javier.gonz@samsung.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	JinHwan Park <jh.i.park@samsung.com>,
	SEUNGUK SHIN <seunguk.shin@samsung.com>,
	Sung-Jun Park <sungjun07.park@samsung.com>,
	yongmyung lee <ymhungry.lee@samsung.com>,
	Jinyoung CHOI <j-young.choi@samsung.com>,
	BoRam Shin <boram.shin@samsung.com>
Subject: RE: Re: [PATCH v25 4/4] scsi: ufs: Add HPB 2.0 support
Date: Wed, 03 Mar 2021 11:31:44 +0900	[thread overview]
Message-ID: <20210303023144epcms2p58b342049ed4aca3287beaedfcbcedf37@epcms2p5> (raw)
In-Reply-To: <f5cb5a04dd25984c4ddf7713ce0ffbbbbb969ea4.camel@gmail.com>

> > 
> >  static void __ufshpb_evict_region(struct ufshpb_lu *hpb,
> >                                    struct ufshpb_region *rgn)
> >  {
> > @@ -1209,6 +1579,16 @@ static void ufshpb_lu_parameter_init(struct
> > ufs_hba *hba,
> >          u32 entries_per_rgn;
> >          u64 rgn_mem_size, tmp;
> >  
> > +        /* for pre_req */
> > +        if (hpb_dev_info->max_hpb_single_cmd)
> > +                hpb->pre_req_min_tr_len = hpb_dev_info-
> > >max_hpb_single_cmd;
> > +        else
> > +                hpb->pre_req_min_tr_len = HPB_MULTI_CHUNK_LOW;
>  
>  
> Here is not correct. according to Spec:
>  
> The size is calculated as ( bMAX_DATA_SIZE_FOR_HPB_SINGLE_CMD +1 )*4KB.
> 00h: 4KB
> 01h: 8KB
> 02h: 12KB
> 03h: 16KB
> ...
> FEh: 1020KB
> FFh: 1024KB
>  
> so, here if hpb_dev_info->max_hpb_single_cmd is 0x00, means 4KB, not
> 36KB.

OK,
 
> > +        hpb->pre_req_max_tr_len = max(HPB_MULTI_CHUNK_HIGH,
> > +                                      hpb->pre_req_min_tr_len);
> > +
> > 
> >  out:
> >          /* All LUs are initialized */
> >          if (atomic_dec_and_test(&hba->ufshpb_dev.slave_conf_cnt))
> > @@ -1812,8 +2307,9 @@ void ufshpb_get_geo_info(struct ufs_hba *hba,
> > u8 *geo_buf)
> >  void ufshpb_get_dev_info(struct ufs_hba *hba, u8 *desc_buf)
> >  {
> >          struct ufshpb_dev_info *hpb_dev_info = &hba->ufshpb_dev;
> > -        int version;
> > +        int version, ret;
> >          u8 hpb_mode;
> > +        u32 max_hpb_sigle_cmd = 0;
> >  
> >          hpb_mode = desc_buf[DEVICE_DESC_PARAM_HPB_CONTROL];
> >          if (hpb_mode == HPB_HOST_CONTROL) {
> > @@ -1824,13 +2320,27 @@ void ufshpb_get_dev_info(struct ufs_hba *hba,
> > u8 *desc_buf)
> >          }
> >  
> >          version = get_unaligned_be16(desc_buf +
> > DEVICE_DESC_PARAM_HPB_VER);
> > -        if (version != HPB_SUPPORT_VERSION) {
> > +        if ((version != HPB_SUPPORT_VERSION) &&
> > +            (version != HPB_SUPPORT_LEGACY_VERSION)) {
> >                  dev_err(hba->dev, "%s: HPB %x version is not
> > supported.\n",
> >                          __func__, version);
> >                  hpb_dev_info->hpb_disabled = true;
> >                  return;
> >          }
> >  
> > +        if (version == HPB_SUPPORT_LEGACY_VERSION)
> > +                hpb_dev_info->is_legacy = true;
> > +
> > +        pm_runtime_get_sync(hba->dev);
> > +        ret = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_READ_ATTR,
> > +                QUERY_ATTR_IDN_MAX_HPB_SINGLE_CMD, 0, 0,
> > &max_hpb_sigle_cmd);
> > +        pm_runtime_put_sync(hba->dev);
> > +
> > +        if (ret)
> > +                dev_err(hba->dev, "%s: idn: read max size of single hpb
> > cmd query request failed",
> > +                        __func__);
> > +        hpb_dev_info->max_hpb_single_cmd = max_hpb_sigle_cmd;
> > +
>  
> Here you didn't add 1, if you read out the
> QUERY_ATTR_IDN_MAX_HPB_SINGLE_CMD == 7, means device can support
> maximum HPB Data size for using single HPB command is 7+1
> ((7+1)*4=32KB), not 7.

OK, Done.

Thanks,
Daejun

  parent reply	other threads:[~2021-03-03 11:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210226073233epcms2p80fca2dffabea03143a9414838f757633@epcms2p8>
2021-02-26  7:32 ` [PATCH v25 0/4] scsi: ufs: Add Host Performance Booster Support Daejun Park
     [not found]   ` <CGME20210226073233epcms2p80fca2dffabea03143a9414838f757633@epcms2p2>
2021-02-26  7:33     ` [PATCH v25 1/4] scsi: ufs: Introduce HPB feature Daejun Park
     [not found]   ` <CGME20210226073233epcms2p80fca2dffabea03143a9414838f757633@epcms2p1>
2021-02-26  7:34     ` [PATCH v25 3/4] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
     [not found]   ` <CGME20210226073233epcms2p80fca2dffabea03143a9414838f757633@epcms2p5>
2021-02-26  7:35     ` [PATCH v25 4/4] scsi: ufs: Add HPB 2.0 support Daejun Park
2021-03-02 12:49       ` Bean Huo
2021-03-02 13:15         ` Avri Altman
2021-03-02 14:32           ` Bean Huo
2021-03-02 13:02       ` Bean Huo
2021-03-02 14:27       ` Bean Huo
2021-03-03  4:05       ` Can Guo
2021-03-03  4:31       ` Can Guo
2021-03-03  2:31     ` Daejun Park [this message]
     [not found]   ` <CGME20210226073233epcms2p80fca2dffabea03143a9414838f757633@epcms2p4>
2021-02-26  7:34     ` [PATCH v25 2/4] scsi: ufs: L2P map management for HPB read Daejun Park
2021-03-03  2:32     ` Re: [PATCH v25 4/4] scsi: ufs: Add HPB 2.0 support Daejun Park
2021-03-03  4:59     ` Daejun Park
2021-03-03  4:58 ` Daejun Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210303023144epcms2p58b342049ed4aca3287beaedfcbcedf37@epcms2p5 \
    --to=daejun7.park@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=avri.altman@wdc.com \
    --cc=boram.shin@samsung.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=huobean@gmail.com \
    --cc=j-young.choi@samsung.com \
    --cc=javier.gonz@samsung.com \
    --cc=jejb@linux.ibm.com \
    --cc=jh.i.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=seunguk.shin@samsung.com \
    --cc=stanley.chu@mediatek.com \
    --cc=sungjun07.park@samsung.com \
    --cc=ymhungry.lee@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®