From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 300C0C15501 for ; Thu, 4 Mar 2021 00:08:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F298F64F9D for ; Thu, 4 Mar 2021 00:08:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354108AbhCDAHr (ORCPT ); Wed, 3 Mar 2021 19:07:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45856 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1389804AbhCCVrP (ORCPT ); Wed, 3 Mar 2021 16:47:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614807945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/LUNLY/w0+Bzk+kXfX0uauiVFlX2RwNcK9iVLBJ9IPA=; b=dg5zI/zy3aUNkARrmQIj+ylWwpGy0D7Qie0G2oseLUZHDEZbqUtIDbx5NAYLR5RQv3drkC 3/uTYgnrPx+VkNAM8yrNy//s5H/2Boi2d3I3b8QriJ0/j4n+ieCVbneU2Zs9As4mauvuZ4 PBwYgrFtYmfK9GmC2WPtus5QPBJLN+E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-475-xR35m5hIMDWHSE7CU3j2Fg-1; Wed, 03 Mar 2021 16:45:42 -0500 X-MC-Unique: xR35m5hIMDWHSE7CU3j2Fg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3C6CB1E561; Wed, 3 Mar 2021 21:45:40 +0000 (UTC) Received: from treble (ovpn-114-218.rdu2.redhat.com [10.10.114.218]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 75A435D741; Wed, 3 Mar 2021 21:45:37 +0000 (UTC) Date: Wed, 3 Mar 2021 15:45:34 -0600 From: Josh Poimboeuf To: Linus Torvalds Cc: Masahiro Yamada , Linux Kernel Mailing List , Michal Marek , linux-hardening@vger.kernel.org, Linux Kbuild mailing list , Peter Zijlstra , Justin Forbes , Ondrej Mosnacek , Frank Eigler , Kees Cook Subject: Re: [PATCH RFC] gcc-plugins: Handle GCC version mismatch for OOT modules Message-ID: <20210303214534.guyoxcwrgxgcqzy4@treble> References: <20210302232649.y2tutffhxsblwqlb@treble> <20210303191516.6ksxmng4pis7ue4p@treble> <20210303193806.oovupl4ubtkkyiih@treble> <20210303202406.bxgdx5a25j6wc43b@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 03, 2021 at 12:56:52PM -0800, Linus Torvalds wrote: > On Wed, Mar 3, 2021 at 12:24 PM Josh Poimboeuf wrote: > > > > Your nack is for a different reason: GCC plugins are second-class > > citizens. Fair enough... > > MNo, I didn't NAK it. Quite the reverser. > > I am ABSOLUTELY against rebuilding normal object files just because > gcc versions change. A compiler version change makes zero difference > for any normal object file. > > But the gcc plugins are different. They very much _are_ tied to a > particular gcc version. > > Now, they are tied to a particular gcc version because they are > horribly badly done, and bad technology, and I went off on a bit of a > rant about just how bad they are, but the point is that gcc plugins > depend on the exact gcc version in ways that normal object files do > _not_. Thanks, reading comprehension is hard. I realized after re-reading that I interpreted your "plugins should depend on the kernel version" statement too broadly. Masahiro, any idea how I can make the GCC version a build dependency? -- Josh