From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1402C433DB for ; Thu, 4 Mar 2021 14:42:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AD8864F42 for ; Thu, 4 Mar 2021 14:42:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232261AbhCDOl6 (ORCPT ); Thu, 4 Mar 2021 09:41:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:57250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232224AbhCDOlb (ORCPT ); Thu, 4 Mar 2021 09:41:31 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7737864F5B; Thu, 4 Mar 2021 14:40:50 +0000 (UTC) Date: Thu, 4 Mar 2021 09:40:49 -0500 From: Steven Rostedt To: Vamshi K Sthambamkadi Cc: mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tracing: fix memory leaks in __create_synth_event() Message-ID: <20210304094049.19554140@gandalf.local.home> In-Reply-To: <20210304094521.GA1826@cosmos> References: <20210304094521.GA1826@cosmos> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 4 Mar 2021 15:15:24 +0530 Vamshi K Sthambamkadi wrote: > To fix call argv_free() even when argc=0. I want to cry :'-( Not anything to do with you. I have a set of fixes that I have queued that requires a ~13 hour test to run before I push off to Linus. When it was almost done, I discovered another bug. Fixed it. Killed the almost completed running test, and restarted it for another 13 hour run. I woke up this morning happy to see that it passed, but then found your patch. Wash, rinse, repeat! :-p Thanks, looks good and I'll apply it. (and start up my 13 hour test again!) -- Steve