From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B91F1C433DB for ; Thu, 4 Mar 2021 11:20:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DFD964F32 for ; Thu, 4 Mar 2021 11:20:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239487AbhCDLUG (ORCPT ); Thu, 4 Mar 2021 06:20:06 -0500 Received: from mga02.intel.com ([134.134.136.20]:24230 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231703AbhCDLUA (ORCPT ); Thu, 4 Mar 2021 06:20:00 -0500 IronPort-SDR: cEXGGmCvqe3XP/p4USSNjHdwiy78GBBso3At+qxBFU9+t8W/plMkTM9z7BCCbIUJe/48WUX1Rg 6XT9wGo7Ivhw== X-IronPort-AV: E=McAfee;i="6000,8403,9912"; a="174510230" X-IronPort-AV: E=Sophos;i="5.81,222,1610438400"; d="scan'208";a="174510230" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2021 03:18:14 -0800 IronPort-SDR: 0IexT2k7f9Mxr2A/jkO4XKOGEFm3Lw2y/Aosl2JEJ1Qnf0m0jAkq2AkqgzqmgV7urv9LyLtNXA lg/U0arftNzA== X-IronPort-AV: E=Sophos;i="5.81,222,1610438400"; d="scan'208";a="384406967" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2021 03:18:12 -0800 Received: by lahna (sSMTP sendmail emulation); Thu, 04 Mar 2021 13:18:09 +0200 Date: Thu, 4 Mar 2021 13:18:09 +0200 From: Mika Westerberg To: Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Linus Walleij Subject: Re: [PATCH v1 1/1] pinctrl: intel: No need to disable IRQs in the handler Message-ID: <20210304111809.GO2542@lahna.fi.intel.com> References: <20210304105432.36544-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210304105432.36544-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 04, 2021 at 12:54:32PM +0200, Andy Shevchenko wrote: > In IRQ handler interrupts are already disabled, hence no need > to repeat it. Even in the threaded case, which is disabled here, > it is not a problem because IRQ framework serializes descriptor > handling. Remove disabling IRQ part in the handler. > > Signed-off-by: Andy Shevchenko Acked-by: Mika Westerberg