From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEB58C43381 for ; Thu, 4 Mar 2021 16:44:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B334364F57 for ; Thu, 4 Mar 2021 16:44:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238239AbhCDQnf (ORCPT ); Thu, 4 Mar 2021 11:43:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234351AbhCDQnZ (ORCPT ); Thu, 4 Mar 2021 11:43:25 -0500 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87E05C061756 for ; Thu, 4 Mar 2021 08:42:45 -0800 (PST) Received: by mail-pf1-x434.google.com with SMTP id r5so19318656pfh.13 for ; Thu, 04 Mar 2021 08:42:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jxMFtpQXBw8+Teasy1N+8sAYQpWswbzlBxa6vG+wy8E=; b=P8VyWheessx6KTbE4i7UGhVaOjZhuvD88bWMyUXOqoCRgF9kaNs3dsLa5n/3xCmYR9 tbNfn+L5JCnN6ZPLKHL4cZjdiawIrwGkAD4Q91UEuSgJLXuqtggozjKE5cXHH4z/uwt9 Yk3jVYtvFfSZf5XclgoKPk0XHI82vJUl+9DBKlrR6zrXi33Sn3t54L4h2vMfJ6qfWveA Egf7V/DK3FDqrWcOvBShodrbVMxeRi6MR8vziSx+sDn/65QaS3FVsue/vcpNvHRYhwaM WJdpscqGQyeg0GiYYkxKMywEaA2qKqZDxlCE7kKQIZF+xk0YZZlf42jnk9IV3hxZ9qbq soHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jxMFtpQXBw8+Teasy1N+8sAYQpWswbzlBxa6vG+wy8E=; b=JZpPHT4sa7dwCERmn2l34jdNwcSicEDkCX8vwJdT3XgAEZyJ3dhdeGUXyiYFYuwB0H 3pMz6/rifUXGoq1fQMwiEDPSk2gwdlVtsIoyZF9MDVL6ZnQGJLwX2av1vnfKjBFDfZJS Oq5SZ8fFpIFYYk4xryCubpVUY/oTyVEjtMZddAroQgJleH73OF9kEJjkE4op+1VCHQA3 TtusuL/jt9dS0N+XBeGgy0qO2XcZY7onbMvJHnvAax/tv+c6nRpzp0n3PuDr6H1kH/hq DFNxrfyQD4MIUqBu9ToCb945oQAOhvFYFdL9CYBfRrR8r3MuEanFenEHk5EU9/5y7TfH C3kg== X-Gm-Message-State: AOAM533sQ2sxHXa+4v69kGugkQJXanw+av0y6j5yDrJB2ZSWT3WxHWWo PmHFsEU8GPprENMym7a3BUs= X-Google-Smtp-Source: ABdhPJyWua5tkLF52KUNjTQ3p3oHFXeHG3+coeIgdK99/J9XbzAJkv98YsQfuqfLpbiA9sHIs+E2dQ== X-Received: by 2002:a63:1d01:: with SMTP id d1mr4229438pgd.361.1614876165138; Thu, 04 Mar 2021 08:42:45 -0800 (PST) Received: from vultr.guest ([141.164.41.4]) by smtp.gmail.com with ESMTPSA id n4sm27881488pfa.188.2021.03.04.08.42.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Mar 2021 08:42:44 -0800 (PST) From: Changbin Du To: Arnaldo Carvalho de Melo , Peter Zijlstra Cc: Ingo Molnar , Jiri Olsa , Namhyung Kim , linux-kernel@vger.kernel.org, Changbin Du Subject: [PATCH v2] perf stat: improve readability of shadow stats Date: Fri, 5 Mar 2021 00:42:35 +0800 Message-Id: <20210304164235.11384-1-changbin.du@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This adds function convert_unit_double() and selects appropriate unit for shadow stats between K/M/G. $ sudo ./perf stat -a -- sleep 1 Before: Unit 'M' is selected even the number is very small. Performance counter stats for 'system wide': 4,003.06 msec cpu-clock # 3.998 CPUs utilized 16,179 context-switches # 0.004 M/sec 161 cpu-migrations # 0.040 K/sec 4,699 page-faults # 0.001 M/sec 6,135,801,925 cycles # 1.533 GHz (83.21%) 5,783,308,491 stalled-cycles-frontend # 94.26% frontend cycles idle (83.21%) 4,543,694,050 stalled-cycles-backend # 74.05% backend cycles idle (66.49%) 4,720,130,587 instructions # 0.77 insn per cycle # 1.23 stalled cycles per insn (83.28%) 753,848,078 branches # 188.318 M/sec (83.61%) 37,457,747 branch-misses # 4.97% of all branches (83.48%) 1.001283725 seconds time elapsed After: $ sudo ./perf stat -a -- sleep 2 Performance counter stats for 'system wide': 8,005.52 msec cpu-clock # 3.999 CPUs utilized 10,715 context-switches # 1.338 K/sec 785 cpu-migrations # 98.057 /sec 102 page-faults # 12.741 /sec 1,948,202,279 cycles # 0.243 GHz 2,816,470,932 stalled-cycles-frontend # 144.57% frontend cycles idle 2,661,172,207 stalled-cycles-backend # 136.60% backend cycles idle 464,172,105 instructions # 0.24 insn per cycle # 6.07 stalled cycles per insn 91,567,662 branches # 11.438 M/sec 7,756,054 branch-misses # 8.47% of all branches 2.002040043 seconds time elapsed Signed-off-by: Changbin Du v2: o do not change 'sec' to 'cpu-sec'. o use convert_unit_double to implement convert_unit. --- tools/perf/util/stat-shadow.c | 16 +++++++--------- tools/perf/util/units.c | 21 ++++++++++++++------- tools/perf/util/units.h | 1 + 3 files changed, 22 insertions(+), 16 deletions(-) diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c index 6ccf21a72f06..3f800e71126f 100644 --- a/tools/perf/util/stat-shadow.c +++ b/tools/perf/util/stat-shadow.c @@ -9,6 +9,7 @@ #include "expr.h" #include "metricgroup.h" #include "cgroup.h" +#include "units.h" #include /* @@ -1270,18 +1271,15 @@ void perf_stat__print_shadow_stats(struct perf_stat_config *config, generic_metric(config, evsel->metric_expr, evsel->metric_events, NULL, evsel->name, evsel->metric_name, NULL, 1, cpu, out, st); } else if (runtime_stat_n(st, STAT_NSECS, cpu, &rsd) != 0) { - char unit = 'M'; - char unit_buf[10]; + char unit = ' '; + char unit_buf[10] = "/sec"; total = runtime_stat_avg(st, STAT_NSECS, cpu, &rsd); - if (total) - ratio = 1000.0 * avg / total; - if (ratio < 0.001) { - ratio *= 1000; - unit = 'K'; - } - snprintf(unit_buf, sizeof(unit_buf), "%c/sec", unit); + ratio = convert_unit_double(1000000000.0 * avg / total, &unit); + + if (unit != ' ') + snprintf(unit_buf, sizeof(unit_buf), "%c/sec", unit); print_metric(config, ctxp, NULL, "%8.3f", unit_buf, ratio); } else if (perf_stat_evsel__is(evsel, SMI_NUM)) { print_smi_cost(config, cpu, out, st, &rsd); diff --git a/tools/perf/util/units.c b/tools/perf/util/units.c index a46762aec4c9..32c39cfe209b 100644 --- a/tools/perf/util/units.c +++ b/tools/perf/util/units.c @@ -33,28 +33,35 @@ unsigned long parse_tag_value(const char *str, struct parse_tag *tags) return (unsigned long) -1; } -unsigned long convert_unit(unsigned long value, char *unit) +double convert_unit_double(double value, char *unit) { *unit = ' '; - if (value > 1000) { - value /= 1000; + if (value > 1000.0) { + value /= 1000.0; *unit = 'K'; } - if (value > 1000) { - value /= 1000; + if (value > 1000.0) { + value /= 1000.0; *unit = 'M'; } - if (value > 1000) { - value /= 1000; + if (value > 1000.0) { + value /= 1000.0; *unit = 'G'; } return value; } +unsigned long convert_unit(unsigned long value, char *unit) +{ + double v = convert_unit_double((double)value, unit); + + return (unsigned long)v; +} + int unit_number__scnprintf(char *buf, size_t size, u64 n) { char unit[4] = "BKMG"; diff --git a/tools/perf/util/units.h b/tools/perf/util/units.h index 99263b6a23f7..ea43e74e3240 100644 --- a/tools/perf/util/units.h +++ b/tools/perf/util/units.h @@ -12,6 +12,7 @@ struct parse_tag { unsigned long parse_tag_value(const char *str, struct parse_tag *tags); +double convert_unit_double(double value, char *unit); unsigned long convert_unit(unsigned long value, char *unit); int unit_number__scnprintf(char *buf, size_t size, u64 n); -- 2.25.1