From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25027C433E0 for ; Fri, 5 Mar 2021 01:21:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0D1964F51 for ; Fri, 5 Mar 2021 01:21:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229575AbhCEBVV (ORCPT ); Thu, 4 Mar 2021 20:21:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:47914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbhCEBVV (ORCPT ); Thu, 4 Mar 2021 20:21:21 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id A8AD864FF0; Fri, 5 Mar 2021 01:21:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1614907280; bh=m4h7ZHJClpaGq4z31HFjlAN1BbQ52JQhKvIB5gkF1OA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gV3fjtZ7OYER8xZbyYzMav33XcDtppeuPKzWbAum91qZLWbgue6N2j0lWoP5Lesq9 8r/lH+nkZkrrs7CqPKd6AvwppXlrL8851hkFWnrCCSWLoYmK1o9gzrdr6pGyuy+AXU J91a9bJZe8LWGJnCKATUTVWlpZDTQYuRy5UIJFig= Date: Thu, 4 Mar 2021 17:21:20 -0800 From: Andrew Morton To: Daniel Lezcano Cc: Andy Shevchenko , "rafael@kernel.org" , Andy Shevchenko , Lukasz Luba , open list Subject: Re: [PATCH 1/2] units: Add the HZ_PER_KHZ macro Message-Id: <20210304172120.437d25238b880f5885e59142@linux-foundation.org> In-Reply-To: <3ffdd3de-c30e-f237-7bd7-2700d426e53a@linaro.org> References: <20210223203004.7219-1-daniel.lezcano@linaro.org> <20210303163125.dcc0a086a939a58ed30750e8@linux-foundation.org> <3ffdd3de-c30e-f237-7bd7-2700d426e53a@linaro.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 4 Mar 2021 13:41:27 +0100 Daniel Lezcano wrote: > > Also, why make them signed types? Negative Hz is physically > > nonsensical. If that upsets some code somewhere because it was dealing > > with signed types then, well, that code needed fixing anyway. > > > > Ditto MILLIWATT_PER_WATT and friends, sigh. > > At the first glance converting to unsigned long should not hurt the > users of this macro. > > The current series introduces the macro and its usage but by converting > the existing type. > > Is it ok if I send a separate series to change the units from L to UL? That's the way to do it...