From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2836C433E0 for ; Fri, 5 Mar 2021 02:41:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A704F64F4C for ; Fri, 5 Mar 2021 02:41:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229609AbhCEClt (ORCPT ); Thu, 4 Mar 2021 21:41:49 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:26170 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbhCEClt (ORCPT ); Thu, 4 Mar 2021 21:41:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614912108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pn33AdVmvC3/0IQYEhPgzHpY70aPmcFl05zItmBqzEA=; b=hAarekMo2bAEOkt8ibSdy2pXYfttXLBjwcOnWM7sl0/FTxlBjsonhtAyjEHkArUIkMerzX krGMidD8dWPDnPNEbXFBlKGDRtYmvQAl8ypsif/APUx8DgD9VTWz54ESYPve+7iEaQB8ez vGnyrhYNHBietrqU72TH6Zl9iXLRCEA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-200-RZYz0z8bNPuQCSne957cWg-1; Thu, 04 Mar 2021 21:41:46 -0500 X-MC-Unique: RZYz0z8bNPuQCSne957cWg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7AFBD57; Fri, 5 Mar 2021 02:41:45 +0000 (UTC) Received: from treble (ovpn-113-161.rdu2.redhat.com [10.10.113.161]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2FC8D5C1A1; Fri, 5 Mar 2021 02:41:43 +0000 (UTC) Date: Thu, 4 Mar 2021 20:41:40 -0600 From: Josh Poimboeuf To: Linus Torvalds Cc: Masahiro Yamada , Linux Kernel Mailing List , Michal Marek , linux-hardening@vger.kernel.org, Linux Kbuild mailing list , Peter Zijlstra , Justin Forbes , Ondrej Mosnacek , Frank Eigler , Kees Cook Subject: Re: [PATCH RFC] gcc-plugins: Handle GCC version mismatch for OOT modules Message-ID: <20210305024140.fv4i4ujreem2w7sw@treble> References: <20210303193806.oovupl4ubtkkyiih@treble> <20210303202406.bxgdx5a25j6wc43b@treble> <20210303214534.guyoxcwrgxgcqzy4@treble> <20210304150812.rzya7ewmerwhe4m4@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 04, 2021 at 11:12:42AM -0800, Linus Torvalds wrote: > On Thu, Mar 4, 2021 at 7:36 AM Masahiro Yamada wrote: > > > > All the kernel-space objects are rebuilt > > when the compiler is upgraded. > > I very much NAK'ed that one. Why did that go in? > > Or maybe I NAK'ed another version of it (I think the one I NAK'ed was > from Josh), and didn't realize that there were multiple ones. This thread is making me dizzy, but I think the patch you NAK'ed from me was different. It just added an error on GCC mismatch with external modules: https://lkml.kernel.org/r/fff056a7c9e6050c2d60910f70b6d99602f3bec4.1611863075.git.jpoimboe@redhat.com though I think you were ok with downgrading it to a warning. -- Josh