From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E48BBC433DB for ; Fri, 5 Mar 2021 11:52:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F0DF6501C for ; Fri, 5 Mar 2021 11:52:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229882AbhCELwC (ORCPT ); Fri, 5 Mar 2021 06:52:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229616AbhCELv2 (ORCPT ); Fri, 5 Mar 2021 06:51:28 -0500 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EB1CC061756 for ; Fri, 5 Mar 2021 03:51:28 -0800 (PST) Received: by mail-pg1-x52c.google.com with SMTP id o10so1203564pgg.4 for ; Fri, 05 Mar 2021 03:51:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NnCGMYkLHHhLzlha7wIoj+XRbzjVqrdLciTxm17dSR0=; b=xw/B0M8/nF/p2drnRDH6KBVl5mOKJeX+aaBaRAYg+cUninCl1/9UT2yQ9zahq+v2s2 EjBjWeatB4wsl/Defd2CJdAwnyCO5P9dcd2JhkC4S3X0RvHt9NljjiRR58+VY/NU/nPS Bg0UQD9wT9KGd5tgTK40QLtEuSyBJ5rfMahIUef7gNC2qFRXQMlopTRQGLP94exZY4gf qj59JJsqjl/J4szSRU5pvo5SMuR9nX9v/Gq+xEyo5LjS1OWjWstFp/z/8tjvIRQ2n6f7 bS3Kec/ozQl+B6Gbv/Hpv4Q+S1QIBKb/zJqLnL/fRpUuK4VFajkoiMqSg/kLR6FCXmnR 0/JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NnCGMYkLHHhLzlha7wIoj+XRbzjVqrdLciTxm17dSR0=; b=jgcjVNPOhxoWRiUJ8n5hVhEh+yJwEt1RoKWuyb4xxg7j3nLzNyzKl9stHg9LydUqAA r84JFCxrau3eOny7RErDvdwHmvNSy6MU6nqxSeFafaNO9lMDXXruKqTWHq+P8Jz4Kads XzDUjbmMaiVVc9wvLldkhDb7ok+9AMr9pUdt2QGJv/lF/tzuIoIYMCaV7yeu9bFicjOq d/5cqKt66o7a9LMP7SaVdVvabTIyzZ9scRTGE8KNKFGbYVG9b9tqsbbWFhXa95YD68bs RjBOtCCsX+6CCSm4oyt8O5hhBWIV8Nviiaoh0B07H7b7KeqFA+dFWqAzShLZgGlPsggw U9Ow== X-Gm-Message-State: AOAM530uc44djGEzdu8iWb6BXO+210DFmf+qnqLmLbddoMkbcWA4YdhB PaFZrkYim/BeqgK9yFnqQ5j8aw== X-Google-Smtp-Source: ABdhPJzWYQ9hY6hwI1KR7IjfqM4m48t7udGV7npDdPdORAFZg8Zmvwi6DFjGg8C7r7xn6zZSPYBRgA== X-Received: by 2002:a65:41c6:: with SMTP id b6mr7996516pgq.7.1614945087509; Fri, 05 Mar 2021 03:51:27 -0800 (PST) Received: from leoy-ThinkPad-X240s ([103.136.125.226]) by smtp.gmail.com with ESMTPSA id q14sm2048018pfh.172.2021.03.05.03.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 03:51:27 -0800 (PST) Date: Fri, 5 Mar 2021 19:51:20 +0800 From: Leo Yan To: Alexandre Truong Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, John Garry , Will Deacon , Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Kemeng Shi , Ian Rogers , Andi Kleen , Kan Liang , Jin Yao , Adrian Hunter , Suzuki K Poulose , Al Grant , James Clark , Wilco Dijkstra Subject: Re: [PATCH RESEND WITH CCs v3 3/4] perf tools: enable dwarf_callchain_users on aarch64 Message-ID: <20210305115120.GA5478@leoy-ThinkPad-X240s> References: <20210304163255.10363-1-alexandre.truong@arm.com> <20210304163255.10363-3-alexandre.truong@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210304163255.10363-3-alexandre.truong@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexandre, On Thu, Mar 04, 2021 at 04:32:54PM +0000, Alexandre Truong wrote: > On arm64, enable dwarf_callchain_users which will be needed > to do a dwarf unwind in order to get the caller of the leaf frame. > > Signed-off-by: Alexandre Truong > Cc: John Garry > Cc: Will Deacon > Cc: Mathieu Poirier > Cc: Leo Yan > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Arnaldo Carvalho de Melo > Cc: Mark Rutland > Cc: Alexander Shishkin > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Kemeng Shi > Cc: Ian Rogers > Cc: Andi Kleen > Cc: Kan Liang > Cc: Jin Yao > Cc: Adrian Hunter > Cc: Suzuki K Poulose > Cc: Al Grant > Cc: James Clark > Cc: Wilco Dijkstra > --- > tools/perf/builtin-report.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c > index 2a845d6cac09..93661a3eaeb1 100644 > --- a/tools/perf/builtin-report.c > +++ b/tools/perf/builtin-report.c > @@ -405,6 +405,10 @@ static int report__setup_sample_type(struct report *rep) > > callchain_param_setup(sample_type); > > + if (callchain_param.record_mode == CALLCHAIN_FP && > + strncmp(rep->session->header.env.arch, "aarch64", 7) == 0) > + dwarf_callchain_users = true; > + I don't have knowledge for dwarf or FP. This patch is suspicious for me that since it only fixes the issue for "perf report" command, but it cannot support "perf script". I did a quick testing for "perf script" command with the test code from patch 04, seems to me it cannot fix the fp omitting issue for "perf script" command: arm64_fp_test 11211 2282.355095: 176307 cycles: aaaac2e40740 f2+0x10 (/root/arm64_fp_test) aaaac2e4061c main+0xc (/root/arm64_fp_test) ffff961fbd24 __libc_start_main+0xe4 (/usr/lib/aarch64-linux-gnu/libc-2.28.so) aaaac2e4065c _start+0x34 (/root/arm64_fp_test) Could you check for this? Thanks! Leo > if (rep->stitch_lbr && (callchain_param.record_mode != CALLCHAIN_LBR)) { > ui__warning("Can't find LBR callchain. Switch off --stitch-lbr.\n" > "Please apply --call-graph lbr when recording.\n"); > -- > 2.23.0 >