From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Bhaskar Chowdhury <unixbhaskar@gmail.com>
Cc: <lgirdwood@gmail.com>, <broonie@kernel.org>, <perex@perex.cz>,
<tiwai@suse.com>, <kuninori.morimoto.gx@renesas.com>,
<gustavoars@kernel.org>, <peter.ujfalusi@ti.com>,
<patches@opensource.cirrus.com>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>, <rdunlap@infradead.org>
Subject: Re: [PATCH] sound: soc: codecs: Fix a spello in the file wm8955.c
Date: Sun, 7 Mar 2021 17:05:02 +0000 [thread overview]
Message-ID: <20210307170502.GE106851@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20210306115151.31759-1-unixbhaskar@gmail.com>
On Sat, Mar 06, 2021 at 05:21:51PM +0530, Bhaskar Chowdhury wrote:
>
> s/sortd/sorted/
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> sound/soc/codecs/wm8955.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/wm8955.c b/sound/soc/codecs/wm8955.c
> index 513df47bd87d..538bb8b0db39 100644
> --- a/sound/soc/codecs/wm8955.c
> +++ b/sound/soc/codecs/wm8955.c
> @@ -151,7 +151,7 @@ static int wm8955_pll_factors(struct device *dev,
> /* The oscilator should run at should be 90-100MHz, and
> * there's a divide by 4 plus an optional divide by 2 in the
> * output path to generate the system clock. The clock table
> - * is sortd so we should always generate a suitable target. */
> + * is sorted so we should always generate a suitable target. */
> target = Fout * 4;
> if (target < 90000000) {
> pll->outdiv = 1;
> --
> 2.26.2
>
Content of the patch looks good, the commit message might need a
little work. The subject line needs to be appropriate for the
subsystem. Would be better to start with "ASoC: wm8955: " and
typo is a more standard term than spello :-)
Thanks,
Charles
next prev parent reply other threads:[~2021-03-07 17:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 11:51 Bhaskar Chowdhury
2021-03-07 17:05 ` Charles Keepax [this message]
2021-03-08 6:50 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210307170502.GE106851@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gustavoars@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@ti.com \
--cc=rdunlap@infradead.org \
--cc=tiwai@suse.com \
--cc=unixbhaskar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®