From: Paul Cercueil <paul@crapouillou.net>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Russell King <linux@armlinux.org.uk>
Cc: od@zcrc.me, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linux-mmc@vger.kernel.org, Paul Cercueil <paul@crapouillou.net>
Subject: [PATCH 1/2] clk: Add clk_get_first_to_set_rate
Date: Sun, 7 Mar 2021 17:07:41 +0000 [thread overview]
Message-ID: <20210307170742.70949-2-paul@crapouillou.net> (raw)
In-Reply-To: <20210307170742.70949-1-paul@crapouillou.net>
The purpose of this function is to be used along with the notifier
mechanism.
When a parent clock can see its rate externally changed at any moment,
and a driver needs a specific clock rate to function, it can register a
notifier on the parent clock, and call clk_set_rate() on the base clock
to adjust its frequency according to the new parent clock.
This works fine, until the base clock has the CLK_SET_RATE_PARENT flag
set. In that case, calling clk_set_rate() on the base clock will call
clk_set_rate() on the parent clock, which will trigger the notifier
again, and we're in a loop.
For that reason, we need to register the notifier on the parent clock of
the first ancestor of the base clock that will effectively modify its
rate when clk_set_rate() is called, which we can now obtain with
clk_get_first_to_set_rate().
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
drivers/clk/clk.c | 9 +++++++++
include/linux/clk.h | 16 ++++++++++++++++
2 files changed, 25 insertions(+)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 5052541a0986..3fd75e283482 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -2450,6 +2450,15 @@ struct clk *clk_get_parent(struct clk *clk)
}
EXPORT_SYMBOL_GPL(clk_get_parent);
+struct clk *clk_get_first_to_set_rate(struct clk *clk)
+{
+ while (clk && (clk->core->flags & CLK_SET_RATE_PARENT))
+ clk = clk_get_parent(clk);
+
+ return clk;
+}
+
+
static struct clk_core *__clk_init_parent(struct clk_core *core)
{
u8 index = 0;
diff --git a/include/linux/clk.h b/include/linux/clk.h
index 266e8de3cb51..f0ea6ac6aa39 100644
--- a/include/linux/clk.h
+++ b/include/linux/clk.h
@@ -766,6 +766,17 @@ struct clk *clk_get_parent(struct clk *clk);
*/
struct clk *clk_get_sys(const char *dev_id, const char *con_id);
+/**
+ * clk_get_first_to_set_rate - get a pointer to the clock that will
+ * effectively modify its rate when clk_set_rate(clk) is called
+ * (might be clk itself, or any ancestor)
+ * @clk: clock source
+ *
+ * Returns struct clk corresponding to the matched clock source, or
+ * NULL on error.
+ */
+struct clk *clk_get_first_to_set_rate(struct clk *clk);
+
/**
* clk_save_context - save clock context for poweroff
*
@@ -928,6 +939,11 @@ static inline struct clk *clk_get_parent(struct clk *clk)
return NULL;
}
+static inline struct clk *clk_get_first_to_set_rate(struct clk *clk)
+{
+ return NULL;
+}
+
static inline struct clk *clk_get_sys(const char *dev_id, const char *con_id)
{
return NULL;
--
2.30.1
next prev parent reply other threads:[~2021-03-07 17:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-07 17:07 [PATCH 0/2] mmc: jz4740: Support PLL frequency changes Paul Cercueil
2021-03-07 17:07 ` Paul Cercueil [this message]
2021-03-13 22:28 ` [PATCH 1/2] clk: Add clk_get_first_to_set_rate Stephen Boyd
2021-03-13 23:09 ` Paul Cercueil
2021-03-07 17:07 ` [PATCH 2/2] mmc: jz4740: Add support for monitoring PLL clock rate changes Paul Cercueil
2021-03-08 3:58 ` kernel test robot
2021-03-08 14:46 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210307170742.70949-2-paul@crapouillou.net \
--to=paul@crapouillou.net \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=od@zcrc.me \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®