From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5032FC4332B for ; Sun, 7 Mar 2021 18:56:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2796F65177 for ; Sun, 7 Mar 2021 18:56:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231657AbhCGSwK (ORCPT ); Sun, 7 Mar 2021 13:52:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231560AbhCGSvn (ORCPT ); Sun, 7 Mar 2021 13:51:43 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17B1BC06175F for ; Sun, 7 Mar 2021 10:51:42 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id a25-20020a1cf0190000b029010b1cbe2dd0so2426521wmb.2 for ; Sun, 07 Mar 2021 10:51:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=Y2nnNS+GqT7TJyAzMEoj0JTe1ldgAoF/8NSEWFXeM7o=; b=XEQinZBvw40UemIVFSBuR4zO0PnieCrZhqNTiebm5YknyluAW+Qcf9Th1X6qlAp+Km 1loBQ1rTmQQIvAOJD9S1K/mZIe27BCd+bS5NfrD46SUPrDGvMLBs9ysvTqEPTueWYKTi fLTZkYWtw4HKxtS5z/GYZDdd1yv3H8B6MyIHguleBb8sVKZkyiUqpP2yJNDa/emhWrIB 3y0zvTXSlWkNpjCowItRt3ThbHtJYxndEfiJtEZY95LtYpv8CLbYF0zFDdUZt9KAmtIl jkNutdkdD/eZ0hUr58UOrXv6Odu4x57f9EugppBGsx1tezPGKMMIVYmGpPIkGtut00BB 8nag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Y2nnNS+GqT7TJyAzMEoj0JTe1ldgAoF/8NSEWFXeM7o=; b=nn92LeS7/2VOuOernJ6clpw8xx3LEKHViFwuVaDmr12TkVfgLD82n2H0lC/dovTcjw myoijBVY9QA3P/NIx+1yTA+4/nJvBkIFCVhdrgTgedBVy0BB0yh9wftlbowBRMFywg9g xHppTicAYX5zWuldKaj3VjD4wWVYWJazG2rSAm0Igr2hCWRU4v4RbEjkmqSNMv/CAg7/ Ry3Ph+QsRTDCzIFphaoMBL45QuQVJDHeLtTLyJyPucXOTVBjU1QeLgpE3YymbY3kA3m/ 4b1CJ2RjPUU8wjnP5F1Lc6ZVrrvLU7O7a3yQc4B+gZHHrXuxefCvGje0APiJEhsm28uN +AVw== X-Gm-Message-State: AOAM533x2s6l5wm8ZtWP02mQtCk9ZL4tvcOS/EzkvAEqRncn7N9q/kEM NNEuonIioQBQUz9u6nBI/fthyw== X-Google-Smtp-Source: ABdhPJxPa1cKfmS4DGjawfyyfLw4AFQi3uDDzViTul/rXsL+C7IFPZJFOn6jby2a5idBqxriDOPXGQ== X-Received: by 2002:a7b:c188:: with SMTP id y8mr18282898wmi.76.1615143101395; Sun, 07 Mar 2021 10:51:41 -0800 (PST) Received: from localhost.localdomain (lns-bzn-59-82-252-141-80.adsl.proxad.net. [82.252.141.80]) by smtp.gmail.com with ESMTPSA id v5sm14842965wmh.2.2021.03.07.10.51.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Mar 2021 10:51:41 -0800 (PST) From: Daniel Lezcano To: cwchoi00@gmail.com Cc: lukasz.luba@arm.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, steven.price@arm.com, MyungJoo Ham , Kyungmin Park , Chanwoo Choi Subject: [PATCH v4 1/4] devfreq: Register devfreq as a cooling device on demand Date: Sun, 7 Mar 2021 19:51:34 +0100 Message-Id: <20210307185137.24925-1-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently the default behavior is to manually having the devfreq backend to register themselves as a devfreq cooling device. Instead of adding the code in the drivers for the thermal cooling device registering, let's provide a flag in the devfreq's profile to tell the common devfreq code to register the newly created devfreq as a cooling device. Suggested-by: Chanwoo Choi Signed-off-by: Daniel Lezcano --- V4: - Replaced thermal_cooling_device_unregister() by devfreq_cooling_unregister() V3: - Rebased on linux-pm branch without units.h - Set the cdev to NULL in case of error - Added description for the cdev field in the devfreq structure V2: - Added is_cooling_device boolean in profile structure - Register cooling device when the is_cooling_device boolean is set - Remove devfreq cooling device registration in the backend drivers V1: - Register devfreq as a cooling device unconditionnally --- drivers/devfreq/devfreq.c | 13 +++++++++++++ include/linux/devfreq.h | 8 ++++++++ 2 files changed, 21 insertions(+) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index bf3047896e41..8a535d4d6083 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include @@ -26,6 +27,7 @@ #include #include #include +#include #include "governor.h" #define CREATE_TRACE_POINTS @@ -935,6 +937,15 @@ struct devfreq *devfreq_add_device(struct device *dev, mutex_unlock(&devfreq_list_lock); + if (devfreq->profile->is_cooling_device) { + devfreq->cdev = devfreq_cooling_em_register(devfreq, NULL); + if (IS_ERR(devfreq->cdev)) { + dev_info(dev, "Failed to register devfreq " + "cooling device\n"); + devfreq->cdev = NULL; + } + } + return devfreq; err_init: @@ -960,6 +971,8 @@ int devfreq_remove_device(struct devfreq *devfreq) if (!devfreq) return -EINVAL; + devfreq_cooling_unregister(devfreq->cdev); + if (devfreq->governor) { devfreq->governor->event_handler(devfreq, DEVFREQ_GOV_STOP, NULL); diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h index 26ea0850be9b..aba7ace11b72 100644 --- a/include/linux/devfreq.h +++ b/include/linux/devfreq.h @@ -98,11 +98,15 @@ struct devfreq_dev_status { * @freq_table: Optional list of frequencies to support statistics * and freq_table must be generated in ascending order. * @max_state: The size of freq_table. + * + * @is_cooling_device: A self-explanatory boolean giving the device a + * cooling effect property. */ struct devfreq_dev_profile { unsigned long initial_freq; unsigned int polling_ms; enum devfreq_timer timer; + bool is_cooling_device; int (*target)(struct device *dev, unsigned long *freq, u32 flags); int (*get_dev_status)(struct device *dev, @@ -156,6 +160,7 @@ struct devfreq_stats { * @suspend_count: suspend requests counter for a device. * @stats: Statistics of devfreq device behavior * @transition_notifier_list: list head of DEVFREQ_TRANSITION_NOTIFIER notifier + * @cdev: Cooling device pointer if the devfreq has cooling property * @nb_min: Notifier block for DEV_PM_QOS_MIN_FREQUENCY * @nb_max: Notifier block for DEV_PM_QOS_MAX_FREQUENCY * @@ -198,6 +203,9 @@ struct devfreq { struct srcu_notifier_head transition_notifier_list; + /* Pointer to the cooling device if used for thermal mitigation */ + struct thermal_cooling_device *cdev; + struct notifier_block nb_min; struct notifier_block nb_max; }; -- 2.17.1