From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A7E4C433E0 for ; Sun, 7 Mar 2021 20:31:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B577C65165 for ; Sun, 7 Mar 2021 20:31:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232944AbhCGUak convert rfc822-to-8bit (ORCPT ); Sun, 7 Mar 2021 15:30:40 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:57509 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232888AbhCGUaP (ORCPT ); Sun, 7 Mar 2021 15:30:15 -0500 Received: from mail-ed1-f72.google.com ([209.85.208.72]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lJ02X-0004J6-VC for linux-kernel@vger.kernel.org; Sun, 07 Mar 2021 20:30:14 +0000 Received: by mail-ed1-f72.google.com with SMTP id r19so3686353edv.3 for ; Sun, 07 Mar 2021 12:30:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=linVnUsAuRvopkT8+cc4aPzS8ei6dMsnrAAlNuxD3Vg=; b=ZA8WwNOoS65TId16Mjn9/Kvp7ldrvhH0paDSjTLjMoqj3zooGLyqtYeC1U6EaeTvpU AEgKTsVPfNDXhnh73kf8+zTcHzniHAXFyCsC2Imo7IiqmxXLrxm97HTvXWCjQPm69RnV 9GnQS6sr3Qz/s4KJOMJL3hZH92sVYxpvhFVQNauyew114veG9dtDQYFLFtZn6+FZgTfA xSPsZo7RKroYDePH+SeQ4/NLdYYOPKI+axNmpd2wYbXnXqHsTAWWeFgPSzFtLeujFT7I LaZ1I7TOwHzHTnkdB9JLGnfg8Wb1hBiqenJbM99KpYJayhMMQDAmfz1XDWA6u5kVEonk KW5A== X-Gm-Message-State: AOAM532RzUU7pBE2p1RCZejx3tFKYBHY5boxPv6PPyFWv6MQQYXMq3mb P//wKAOWfVFEh2tQB1Vyvuz4U534sIMs7h19BHv02ks5jPHNqb9r6SquGl9ws8qztQJyWcqmIgF 8pmNGoUscezakfOYE9PKe1/njABjV/EiyydHg+sV+rg== X-Received: by 2002:aa7:ce1a:: with SMTP id d26mr19144222edv.206.1615149013742; Sun, 07 Mar 2021 12:30:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJzyuO7zfNCQa4wffaBAkwM2HqU9slERv1JFTpTZyinaoxNp7ZnfInaLxSBY3fiWu1MbSBfJDw== X-Received: by 2002:aa7:ce1a:: with SMTP id d26mr19144200edv.206.1615149013496; Sun, 07 Mar 2021 12:30:13 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id b4sm6354332edh.40.2021.03.07.12.30.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Mar 2021 12:30:12 -0800 (PST) From: Krzysztof Kozlowski X-Google-Original-From: Krzysztof Kozlowski Date: Sun, 7 Mar 2021 21:30:11 +0100 To: Marek Szyprowski Cc: Rob Herring , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , Sylwester Nawrocki Subject: Re: [PATCH v3 2/3] ARM: dts: exynos: Add assigned clock parent to CMU in Exynos4412 Odroid Message-ID: <20210307203011.zeylib7afgvc5zhd@kozik-lap> References: <20200906142146.21266-1-krzk@kernel.org> <20200906142146.21266-2-krzk@kernel.org> <20200911145403.GC15290@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2020 at 11:42:40AM +0200, Marek Szyprowski wrote: > Hi Krzysztof, > > On 11.09.2020 16:54, Krzysztof Kozlowski wrote: > > On Sun, Sep 06, 2020 at 04:21:45PM +0200, Krzysztof Kozlowski wrote: > >> Commit 68605101460e ("ARM: dts: exynos: Add support for audio over HDMI > >> for Odroid X/X2/U3") added assigned clocks under Clock Management Unit. > >> > >> However the dtschema expects "clocks" property if "assigned-clocks" are > >> used. Add reference to input clock, the parent used in > >> "assigned-clock-parents" to silence the dtschema warnings: > >> > >> arch/arm/boot/dts/exynos4412-odroidu3.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks' > >> > > Applied. > > This patch breaks operation of clocks on Odroid X2/U3: > > # dmesg | grep clk > [    0.000000] exynos_clkout_init: failed to register clkout clock > [    0.000000] Exynos4x12 clocks: sclk_apll = 1000000000, sclk_mpll = > 800000000 >                 sclk_epll = 45158401, sclk_vpll = 350000000, arm_clk = > 1000000000 > [    2.569484] usb3503 0-0008: unable to request refclk (-517) > [    2.848718] s3c-sdhci 12530000.sdhci: clock source 2: mmc_busclk.2 > (50000000 Hz) > [    3.373850] usb3503 0-0008: unable to request refclk (-517) > [    3.542777] usb3503 0-0008: unable to request refclk (-517) > [    3.544005] usb3503 0-0008: unable to request refclk (-517) > [    3.559223] usb3503 0-0008: unable to request refclk (-517) > > Please revert or drop if possible. I re-applied this one (it was once reverted), as clkout was converted to proper driver. My Odroid U3 boots fine now with this patch. Best regards, Krzysztof