From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37452C433E0 for ; Tue, 9 Mar 2021 05:38:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF7186523C for ; Tue, 9 Mar 2021 05:38:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229530AbhCIFho (ORCPT ); Tue, 9 Mar 2021 00:37:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:41020 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbhCIFhS (ORCPT ); Tue, 9 Mar 2021 00:37:18 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7D6716518A; Tue, 9 Mar 2021 05:37:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1615268238; bh=hmD3UkvOhmgPEIlYWZbQKRstKfX1ya1CgO7lMiascIs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XZkoUB40gNnfL6kAGhMzXQRkkzQB6m3VlAdwXsRpOoHrHV0Wv3Ik0RyUJn3ka1uO6 hguzcqaFTNFg3yOFcd8ZTLc9hUBsULQgA+Ok6f5lyQsy2yzEh75nmDaFnXN74Sp05v 6hgporgleSYRcjT1wHzpIndsktCaAgq9LDQvmlWY= Date: Mon, 8 Mar 2021 21:37:17 -0800 From: Andrew Morton To: Phillip Lougher Cc: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] Squashfs: fix xattr id and id lookup sanity checks Message-Id: <20210308213717.e319cbf5675a5e427efbdded@linux-foundation.org> In-Reply-To: <2069685113.2081245.1614583677427@webmail.123-reg.co.uk> References: <2069685113.2081245.1614583677427@webmail.123-reg.co.uk> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Mar 2021 07:27:57 +0000 (GMT) Phillip Lougher wrote: > The checks for maximum metadata block size is > missing SQUASHFS_BLOCK_OFFSET (the two byte length > count). There is no definition of SQUASHFS_BLOCK_OFFSET. Makes compiler unhappy.