From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66123C4332B for ; Tue, 9 Mar 2021 09:03:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41ABB6526C for ; Tue, 9 Mar 2021 09:03:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230027AbhCIJDE (ORCPT ); Tue, 9 Mar 2021 04:03:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229851AbhCIJC3 (ORCPT ); Tue, 9 Mar 2021 04:02:29 -0500 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 024FBC061760 for ; Tue, 9 Mar 2021 01:02:29 -0800 (PST) Received: by mail-pl1-x62d.google.com with SMTP id w7so2749908pll.8 for ; Tue, 09 Mar 2021 01:02:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=u8ArZQ+KHFSvmT08uvy27XesXoPhuLhAZbHVQzDz71U=; b=TTMen7rmz9A5cwnAhB1I1c3j/wk9evkRPeSQQGW+a3khDM1AnhEVP2EX5mHXYn7+3W +MWTIlYiaixVr7fWXU7O+9Ur72ieA1NaYAbJzjAjHGRzJ+ad+T+0PAyIdeROL5Tbtken WuPBVa3QHKQ0bfopO/dIyPXLu3/d8ZOUME10Ui3i1YHS9dyadoSDR/aFGQIf/BAf539t lvSXhV0rgGxjEQuZDOkWG2Fzs1UdlLmftPjsKk7lf8QUwHnX+KYIAUtjcBhDtRz+i5Xp DtT5De+c/cYyhdIWuorCuQLEXfD1nF9ijPKuCrrID6L3KjEveRLE17YHFfjMGOQxbUM5 J0Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=u8ArZQ+KHFSvmT08uvy27XesXoPhuLhAZbHVQzDz71U=; b=SlkvwMH/8NUd4ryw4Zj+QFgqIa0AamowSL6g1ExvJ/DHrtOHiFXVPaZHhZ7Vf2Uhvb xnUvH5ZTvCjEx6+AyLBFpp2ECprEu32EIj3OT8GwSx0o4kV5Rq9PgCmvg419R5Qc149j OoRR6o/io2ZN0oEwrduX2CiQ7TrUWaB1eizfIwnvVGu3wImL50X7yNSjNYHz//NjH8+n /rPNy8nVK0zIs+C9GD9wiaJ3KyNQy5Xse+DOqnzQpWNv+sXRpCnDZLO9RCvchyxrMJPW NnqG7ZyjJTkul1PPJczg3Ia3RyWe2Xr2hwyZceWgezttbUOYPW+RW0G5p2jK/O62GIie GKTw== X-Gm-Message-State: AOAM533w0tloQCMoEISwWs1c2+jAGtDP5XmHA/kEXbA9cEVNP4SIFr2e 8qx8QI44FJ48khavFvaVqXs= X-Google-Smtp-Source: ABdhPJyshDQSFkreK/47GHrolspCwwxZDlmp4r7dRsLECu5plzyAoQXxM2XYGHyyiZRxl1JrPbnO3A== X-Received: by 2002:a17:90a:16d6:: with SMTP id y22mr3739120pje.55.1615280548564; Tue, 09 Mar 2021 01:02:28 -0800 (PST) Received: from localhost.localdomain ([45.135.186.97]) by smtp.gmail.com with ESMTPSA id b14sm12469114pfi.74.2021.03.09.01.02.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 01:02:28 -0800 (PST) From: Jia-Ju Bai To: bigeasy@linutronix.de Cc: linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] kernel: profile: fix error return code of create_proc_profile() Date: Tue, 9 Mar 2021 01:02:15 -0800 Message-Id: <20210309090215.25669-1-baijiaju1990@gmail.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When proc_create() returns NULL to entry, no error return code of create_proc_profile() is assigned. To fix this bug, err is assigned with -ENOMEM in this case. Fixes: e722d8daafb9 ("profile: Convert to hotplug state machine") Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- kernel/profile.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/profile.c b/kernel/profile.c index 6f69a4195d56..65bf03bb8a5e 100644 --- a/kernel/profile.c +++ b/kernel/profile.c @@ -549,8 +549,10 @@ int __ref create_proc_profile(void) #endif entry = proc_create("profile", S_IWUSR | S_IRUGO, NULL, &profile_proc_ops); - if (!entry) + if (!entry) { + err = -ENOMEM; goto err_state_onl; + } proc_set_size(entry, (1 + prof_len) * sizeof(atomic_t)); return err; -- 2.17.1