mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Phong Hoang" <phong.hoang.wz@renesas.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	"Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Subject: Re: [PATCH] clocksource: sh_cmt: use CMTOUT_IE only when supported
Date: Tue, 9 Mar 2021 10:35:25 +0100	[thread overview]
Message-ID: <20210309093525.GB2538@ninjato> (raw)
In-Reply-To: <CAMuHMdX9f_G9zMR4=snbHUOP0ufNg8CvSxX8P6+W-z7hBRbQ2g@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]


> But given my comments below, I think it would make sense to change the
> one-line summary to e.g. "clocksource: sh_cmt: R-Car Gen2/Gen3 do not
> have CMTOUT_IE".

Makes sense. I will resend.

> SH_CMT_48BIT:
> sh73a0/r8a7740: CMTOUT_IE supported on channels 1/2/3, not on 0/4/5

Oh, I didn't spot this, sorry!

> So even not all older models support this bit.
> Probably this bit should only be set when the timer is configured as a
> wake-up source.  But that is out-of-scope for this patch.

Ack.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-03-09  9:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05 13:28 Wolfram Sang
2021-03-08  8:35 ` Geert Uytterhoeven
2021-03-09  9:35   ` Wolfram Sang [this message]
2021-03-08 12:04 ` Niklas Söderlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210309093525.GB2538@ninjato \
    --to=wsa+renesas@sang-engineering.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=niklas.soderlund@ragnatech.se \
    --cc=phong.hoang.wz@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®