From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29FB9C433E6 for ; Wed, 10 Mar 2021 02:55:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDC6364FE8 for ; Wed, 10 Mar 2021 02:55:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232193AbhCJCz0 (ORCPT ); Tue, 9 Mar 2021 21:55:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232004AbhCJCyx (ORCPT ); Tue, 9 Mar 2021 21:54:53 -0500 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBB12C06174A for ; Tue, 9 Mar 2021 18:54:53 -0800 (PST) Received: by mail-pg1-x534.google.com with SMTP id p21so10397253pgl.12 for ; Tue, 09 Mar 2021 18:54:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=F7L2rfwUmYIB7S+xDvEKqrJHTr/uik/Q3th44+Fbt0s=; b=CzYw2jEQodgFUJkFkDCkjqeMhkZ/maXPSsR6uL5nluiwEGymjIwN6FaDnhBr6C8qZX QnnK1649X6ZSZEjfjSM096wR1FImuJXXS0L0LpF/kViYWtWBHPrKsWb5p/b9iVB91TQX /1PZQh5T/WjCzTDF4QmHBVP+Ch6cLXz6dcC9P3dMitAXW9POtDU/eR/MrcjpGsNmPESp 8S6UUzmZLu9xJdMztduwcTIeZrTUAYOC6puynMFFQO/vDRQXFWbsQfoFYqHevvDQEHLD IqHuULYzeBYvJ1O3KoapWQ2Mzd6P563s4SM+HCJ2DoFduuwRVaNU3ZB0EkUhsdF9OLth MsUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=F7L2rfwUmYIB7S+xDvEKqrJHTr/uik/Q3th44+Fbt0s=; b=J5wGY2mm52bgxX/Fiihll3GsRAi5uPWqRA02CI2DWqUDCc2eNG18kZCosTACQtkZ3F 7cuBvdd1aracfwi6LA/rc2LVPGwwGf+lzqI1UDwoQHhhmzk2heke4fM5dpCJseSzk/He Stv33GeTDVyAhmGHtU4oLsEGuyzuH5ao1NWA35AMA3ip1VoPqAbopeK3OykQqBa/NYmn Kns/E+r4ckIIvLUxAF0lFki1wRBEeqrsqloXjYGvRaiXnfi/Hi+E42/m1VrwwBYbQS9m 9wiyQOkE6Xkf6Mxyc1s3xaGWcLi83EJk7T/XVNjlxk87iSzluTitTno6xGpXCruXA5k5 /L9g== X-Gm-Message-State: AOAM531WpWnK6iCyUXYiNZEkm3iIN+POZk1S3Wcxv+57Nprmg4b9bQTi dWltBoVMwexspGt40E9tViBvcUd416/c3A== X-Google-Smtp-Source: ABdhPJxy3zQnKdDxFnFa4MAF0F/2s0x0egEHF+1b/xyt2pTLAUFBzQ5G1nVeO1qogvOJVDwEg+/8WA== X-Received: by 2002:a62:1911:0:b029:1ed:b722:3b50 with SMTP id 17-20020a6219110000b02901edb7223b50mr1094613pfz.70.1615344893238; Tue, 09 Mar 2021 18:54:53 -0800 (PST) Received: from localhost ([122.171.124.15]) by smtp.gmail.com with ESMTPSA id fa21sm4034926pjb.25.2021.03.09.18.54.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Mar 2021 18:54:52 -0800 (PST) Date: Wed, 10 Mar 2021 08:24:50 +0530 From: Viresh Kumar To: Ionela Voinescu Cc: Rafael Wysocki , Catalin Marinas , Will Deacon , Sudeep Holla , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Vincent Guittot , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V5 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback Message-ID: <20210310025450.plggnrhbsrpycteq@vireshk-i7> References: <20210309151157.GB25243@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210309151157.GB25243@arm.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09-03-21, 15:11, Ionela Voinescu wrote: > On Monday 01 Mar 2021 at 12:21:17 (+0530), Viresh Kumar wrote: > > diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h > > index 0f6cd6b73a61..3bcfba5c21a7 100644 > > --- a/include/linux/arch_topology.h > > +++ b/include/linux/arch_topology.h > > @@ -34,7 +34,19 @@ void topology_set_freq_scale(const struct cpumask *cpus, unsigned long cur_freq, > > unsigned long max_freq); > > bool topology_scale_freq_invariant(void); We don't normally add blank lines between declarations (variables or function), like what's done here. > > > > -bool arch_freq_counters_available(const struct cpumask *cpus); > > +enum scale_freq_source { > > + SCALE_FREQ_SOURCE_CPUFREQ = 0, > > + SCALE_FREQ_SOURCE_ARCH, > > +}; > > + > > +struct scale_freq_data { > > + enum scale_freq_source source; > > + void (*set_freq_scale)(void); > > +}; > > + > > +void topology_scale_freq_tick(void); > > +void topology_set_scale_freq_source(struct scale_freq_data *data, const struct cpumask *cpus); > > +void topology_clear_scale_freq_source(enum scale_freq_source source, const struct cpumask *cpus); > > Nit: can you split these lines? And so in order to be consistent across the file, I haven't added one here. -- viresh