From: Alexey Gladkov <gladkov.alexey@gmail.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Kees Cook <keescook@chromium.org>
Subject: Re: [RESEND PATCH v4 0/3] proc: Relax check of mount visibility
Date: Wed, 10 Mar 2021 19:22:29 +0100 [thread overview]
Message-ID: <20210310182229.dynrgsxejnfkp3f2@example.org> (raw)
In-Reply-To: <m1zgzwm7iv.fsf@fess.ebiederm.org>
On Mon, Feb 22, 2021 at 09:44:40AM -0600, Eric W. Biederman wrote:
> Alexey Gladkov <gladkov.alexey@gmail.com> writes:
>
> > If only the dynamic part of procfs is mounted (subset=pid), then there is no
> > need to check if procfs is fully visible to the user in the new user
> > namespace.
>
>
> A couple of things.
>
> 1) Allowing the mount should come in the last patch. So we don't have a
> bisect hazard.
>
> 2) We should document that we still require a mount of proc to match on
> atime and readonly mount attributes.
Ok. I will try to do it in v5.
> 3) If we can find a way to safely not require a previous mount of proc
> this will be much more valuable.
True, but for now I have no idea how to do it. I would prefer to move in
small steps.
--
Rgrds, legion
prev parent reply other threads:[~2021-03-10 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 8:21 Alexey Gladkov
2021-02-17 8:21 ` [RESEND PATCH v4 1/3] " Alexey Gladkov
2021-02-17 8:21 ` [RESEND PATCH v4 2/3] proc: Show /proc/self/net only for CAP_NET_ADMIN Alexey Gladkov
2021-02-17 8:21 ` [RESEND PATCH v4 3/3] proc: Disable cancellation of subset=pid option Alexey Gladkov
2021-02-22 15:44 ` [RESEND PATCH v4 0/3] proc: Relax check of mount visibility Eric W. Biederman
2021-03-10 18:22 ` Alexey Gladkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310182229.dynrgsxejnfkp3f2@example.org \
--to=gladkov.alexey@gmail.com \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®