From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0361EC433E9 for ; Fri, 12 Mar 2021 00:29:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C148164F90 for ; Fri, 12 Mar 2021 00:29:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230179AbhCLA3Q (ORCPT ); Thu, 11 Mar 2021 19:29:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229476AbhCLA2u (ORCPT ); Thu, 11 Mar 2021 19:28:50 -0500 Received: from mail.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DF02C061574; Thu, 11 Mar 2021 16:28:50 -0800 (PST) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id F3F154D0ECDFA; Thu, 11 Mar 2021 16:28:48 -0800 (PST) Date: Thu, 11 Mar 2021 16:28:45 -0800 (PST) Message-Id: <20210311.162845.1107113962810628804.davem@davemloft.net> To: joel@jms.id.au Cc: dylan_hung@aspeedtech.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ratbert@faraday-tech.com, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, BMC-SW@aspeedtech.com Subject: Re: [PATCH 4/4] ftgmac100: Restart MAC HW once From: David Miller In-Reply-To: References: <20201019085717.32413-5-dylan_hung@aspeedtech.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Thu, 11 Mar 2021 16:28:49 -0800 (PST) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joel Stanley Date: Fri, 12 Mar 2021 00:26:43 +0000 > On Tue, 20 Oct 2020 at 04:14, Joel Stanley wrote: >> >> On Mon, 19 Oct 2020 at 08:57, Dylan Hung wrote: >> > >> > The interrupt handler may set the flag to reset the mac in the future, >> > but that flag is not cleared once the reset has occured. >> > >> > Fixes: 10cbd6407609 ("ftgmac100: Rework NAPI & interrupts handling") >> > Signed-off-by: Dylan Hung >> > Signed-off-by: Joel Stanley >> >> Reviewed-by: Joel Stanley > > net maintainers, this one never made it into the tree. Do you need me > to re-send it? If it has been this long, definitely you need to resend.