From: Matthew Wilcox <willy@infradead.org>
To: "chenjun (AM)" <chenjun102@huawei.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>, Jan Kara <jack@suse.cz>,
"Xiangrui (Euler)" <rui.xiang@huawei.com>,
"lizhe (Y)" <lizhe67@huawei.com>,
yangerkun <yangerkun@huawei.com>,
"zhangyi (F)" <yi.zhang@huawei.com>
Subject: Re: [question] Panic in dax_writeback_one
Date: Thu, 11 Mar 2021 12:19:23 +0000 [thread overview]
Message-ID: <20210311121923.GU3479805@casper.infradead.org> (raw)
In-Reply-To: <CE1E7D7EFA066443B6454A6A5063B50220D0B849@dggeml509-mbs.china.huawei.com>
On Thu, Mar 11, 2021 at 07:48:25AM +0000, chenjun (AM) wrote:
> static int dax_writeback_one(struct xa_state *xas, struct dax_device
> *dax_dev, struct address_space *mapping, void *entry)
> ----dax_flush(dax_dev, page_address(pfn_to_page(pfn)), count * PAGE_SIZE);
> The pfn is returned by the driver. In my case, the pfn does not have
> struct page. so pfn_to_page(pfn) return a wrong address.
I wasn't involved, but I think the right solution here is simply to
replace page_address(pfn_to_page(pfn)) with pfn_to_virt(pfn). I don't
know why Dan decided to do this in the more complicated way.
next prev parent reply other threads:[~2021-03-11 12:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 7:48 chenjun (AM)
2021-03-11 12:19 ` Matthew Wilcox [this message]
2021-03-11 17:25 ` Dan Williams
2021-03-17 2:59 ` chenjun (AM)
2021-03-17 4:55 ` Dan Williams
2021-03-17 6:45 ` chenjun (AM)
2021-03-12 2:40 ` chenjun (AM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210311121923.GU3479805@casper.infradead.org \
--to=willy@infradead.org \
--cc=chenjun102@huawei.com \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhe67@huawei.com \
--cc=rui.xiang@huawei.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®