From: Masami Hiramatsu <mhiramat@kernel.org>
To: Cao jin <jojing64@gmail.com>
Cc: linux-kernel@vger.kernel.org, mhiramat@kernel.org,
akpm@linux-foundation.org, rostedt@goodmis.org,
keescook@chromium.org, vbabka@suse.cz
Subject: Re: [PATCH] bootconfig: Update prototype of setup_boot_config()
Date: Thu, 11 Mar 2021 18:50:21 +0900 [thread overview]
Message-ID: <20210311185021.cd7a42057c8500755e3732a7@kernel.org> (raw)
In-Reply-To: <20210311085213.27680-1-jojing64@gmail.com>
On Thu, 11 Mar 2021 16:52:13 +0800
Cao jin <jojing64@gmail.com> wrote:
> Parameter "cmdline" has no use, drop it.
OK, this looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you,
>
> Signed-off-by: Cao jin <jojing64@gmail.com>
> ---
> init/main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/init/main.c b/init/main.c
> index c68d784376ca..621a11ed18fb 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -404,7 +404,7 @@ static int __init bootconfig_params(char *param, char *val,
> return 0;
> }
>
> -static void __init setup_boot_config(const char *cmdline)
> +static void __init setup_boot_config(void)
> {
> static char tmp_cmdline[COMMAND_LINE_SIZE] __initdata;
> const char *msg;
> @@ -471,7 +471,7 @@ static void __init setup_boot_config(const char *cmdline)
>
> #else
>
> -static void __init setup_boot_config(const char *cmdline)
> +static void __init setup_boot_config(void)
> {
> /* Remove bootconfig data from initrd */
> get_boot_config_from_initrd(NULL, NULL);
> @@ -869,7 +869,7 @@ asmlinkage __visible void __init __no_sanitize_address start_kernel(void)
> pr_notice("%s", linux_banner);
> early_security_init();
> setup_arch(&command_line);
> - setup_boot_config(command_line);
> + setup_boot_config();
> setup_command_line(command_line);
> setup_nr_cpu_ids();
> setup_per_cpu_areas();
> --
> 2.29.2
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2021-03-11 9:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 8:52 Cao jin
2021-03-11 9:50 ` Masami Hiramatsu [this message]
2021-03-11 14:04 ` Steven Rostedt
2021-03-12 1:44 ` Masami Hiramatsu
2021-03-12 15:11 ` Steven Rostedt
2021-03-11 14:03 ` Steven Rostedt
2021-03-12 2:10 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210311185021.cd7a42057c8500755e3732a7@kernel.org \
--to=mhiramat@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=jojing64@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®