From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: perex@perex.cz, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, lgirdwood@gmail.com
Subject: Re: [PATCH 3/7] ASoC: codecs: wcd938x: add basic driver
Date: Fri, 12 Mar 2021 15:34:43 +0000 [thread overview]
Message-ID: <20210312153443.GI5348@sirena.org.uk> (raw)
In-Reply-To: <20210311173416.25219-4-srinivas.kandagatla@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 457 bytes --]
On Thu, Mar 11, 2021 at 05:34:12PM +0000, Srinivas Kandagatla wrote:
> +static int wcd9380_update_status(struct sdw_slave *slave,
> + enum sdw_slave_status status)
> +{
> + return 0;
> +}
> +
> +static int wcd9380_port_prep(struct sdw_slave *slave,
> + struct sdw_prepare_ch *prepare_ch,
> + enum sdw_port_prep_ops state)
> +{
> + return 0;
> +}
If these can legitimately be empty I'd expect the framework to support
them being omitted.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-12 15:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 17:34 [PATCH 0/7] ASoC: codecs: add wcd938x support Srinivas Kandagatla
2021-03-11 17:34 ` [PATCH 1/7] ASoC: dt-bindings: wcd938x: add bindings for wcd938x Srinivas Kandagatla
2021-03-12 15:21 ` Mark Brown
2021-03-15 10:05 ` Srinivas Kandagatla
2021-03-11 17:34 ` [PATCH 2/7] ASoC: codecs: wcd-clsh: add new version support Srinivas Kandagatla
2021-03-11 17:34 ` [PATCH 3/7] ASoC: codecs: wcd938x: add basic driver Srinivas Kandagatla
2021-03-12 15:34 ` Mark Brown [this message]
2021-03-15 10:04 ` Srinivas Kandagatla
2021-03-11 17:34 ` [PATCH 4/7] ASoC: codecs: wcd938x: add basic controls Srinivas Kandagatla
2021-03-12 15:55 ` Mark Brown
2021-03-15 10:04 ` Srinivas Kandagatla
2021-03-11 17:34 ` [PATCH 5/7] ASoC: codecs: wcd938x: add playback dapm widgets Srinivas Kandagatla
2021-03-11 17:34 ` [PATCH 6/7] ASoC: codecs: wcd938x: add capture " Srinivas Kandagatla
2021-03-11 17:34 ` [PATCH 7/7] ASoC: codecs: wcd938x: add audio routing Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210312153443.GI5348@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome