mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Sebastian Reichel <sre@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	kernel@collabora.com, Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org
Subject: [PATCH 01/38] ARM: dts: motorola-cpcap-mapphone: Prepare for dtbs_check parsing
Date: Fri, 12 Mar 2021 16:43:20 +0100	[thread overview]
Message-ID: <20210312154357.1561730-2-sebastian.reichel@collabora.com> (raw)
In-Reply-To: <20210312154357.1561730-1-sebastian.reichel@collabora.com>

'<&gpio1 parameters &gpio2 parameters>' and '<&gpio1 parameters>,
<&gpio2 parameters>' result in the same DTB, but second format has
better source code readability. Also 'dtbs_check' currently uses
this format to determine the amount of items specified, so using
this syntax is needed to successfully verify the devicetree source
against a DT schema format.

Cc: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 .../arm/boot/dts/motorola-cpcap-mapphone.dtsi | 59 +++++++++----------
 1 file changed, 28 insertions(+), 31 deletions(-)

diff --git a/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi b/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi
index 08a7d3ce383f..ea02fd403a9b 100644
--- a/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi
+++ b/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi
@@ -27,16 +27,14 @@ cpcap_adc: adc {
 
 		cpcap_battery: battery {
 			compatible = "motorola,cpcap-battery";
-			interrupts-extended = <
-				&cpcap 6 0 &cpcap 5 0 &cpcap 3 0
-				&cpcap 20 0 &cpcap 54 0 &cpcap 57 0
-			>;
+			interrupts-extended =
+				<&cpcap 6 0>, <&cpcap 5 0>, <&cpcap 3 0>,
+				<&cpcap 20 0>, <&cpcap 54 0>, <&cpcap 57 0>;
 			interrupt-names =
 				"eol", "lowbph", "lowbpl",
-				"chrgcurr1", "battdetb",
-				"cccal";
-			io-channels = <&cpcap_adc 0 &cpcap_adc 1
-				       &cpcap_adc 5 &cpcap_adc 6>;
+				"chrgcurr1", "battdetb", "cccal";
+			io-channels = <&cpcap_adc 0>, <&cpcap_adc 1>,
+				      <&cpcap_adc 5>, <&cpcap_adc 6>;
 			io-channel-names = "battdetb", "battp",
 					   "chg_isense", "batti";
 			power-supplies = <&cpcap_charger>;
@@ -44,20 +42,19 @@ &cpcap 20 0 &cpcap 54 0 &cpcap 57 0
 
 		cpcap_charger: charger {
 			compatible = "motorola,mapphone-cpcap-charger";
-			interrupts-extended = <
-				&cpcap 13 0 &cpcap 12 0 &cpcap 29 0 &cpcap 28 0
-				&cpcap 22 0 &cpcap 21 0 &cpcap 20 0 &cpcap 19 0
-				&cpcap 54 0
-			>;
+			interrupts-extended =
+				<&cpcap 13 0>, <&cpcap 12 0>, <&cpcap 29 0>,
+				<&cpcap 28 0>, <&cpcap 22 0>, <&cpcap 21 0>,
+				<&cpcap 20 0>, <&cpcap 19 0>, <&cpcap 54 0>;
 			interrupt-names =
-				"chrg_det", "rvrs_chrg", "chrg_se1b", "se0conn",
-				"rvrs_mode", "chrgcurr2", "chrgcurr1", "vbusvld",
-				"battdetb";
-			mode-gpios = <&gpio3 29 GPIO_ACTIVE_LOW
-				      &gpio3 23 GPIO_ACTIVE_LOW>;
-			io-channels = <&cpcap_adc 0 &cpcap_adc 1
-				       &cpcap_adc 2 &cpcap_adc 5
-				       &cpcap_adc 6>;
+				"chrg_det", "rvrs_chrg", "chrg_se1b",
+				"se0conn", "rvrs_mode", "chrgcurr2",
+				"chrgcurr1", "vbusvld", "battdetb";
+			mode-gpios = <&gpio3 29 GPIO_ACTIVE_LOW>,
+				     <&gpio3 23 GPIO_ACTIVE_LOW>;
+			io-channels = <&cpcap_adc 0>, <&cpcap_adc 1>,
+				      <&cpcap_adc 2>, <&cpcap_adc 5>,
+				      <&cpcap_adc 6>;
 			io-channel-names = "battdetb", "battp",
 					   "vbus", "chg_isense",
 					   "batti";
@@ -98,22 +95,22 @@ power_button: button {
 
 		cpcap_usb2_phy: phy {
 			compatible = "motorola,mapphone-cpcap-usb-phy";
-			pinctrl-0 = <&usb_gpio_mux_sel1 &usb_gpio_mux_sel2>;
+			pinctrl-0 = <&usb_gpio_mux_sel1>, <&usb_gpio_mux_sel2>;
 			pinctrl-1 = <&usb_ulpi_pins>;
 			pinctrl-2 = <&usb_utmi_pins>;
 			pinctrl-3 = <&uart3_pins>;
 			pinctrl-names = "default", "ulpi", "utmi", "uart";
 			#phy-cells = <0>;
-			interrupts-extended = <
-				&cpcap 15 0 &cpcap 14 0 &cpcap 28 0 &cpcap 19 0
-				&cpcap 18 0 &cpcap 17 0 &cpcap 16 0 &cpcap 49 0
-				&cpcap 48 0
-			>;
+			interrupts-extended =
+				<&cpcap 15 0>, <&cpcap 14 0>, <&cpcap 28 0>,
+				<&cpcap 19 0>, <&cpcap 18 0>, <&cpcap 17 0>,
+				<&cpcap 16 0>, <&cpcap 49 0>, <&cpcap 48 0>;
 			interrupt-names =
-				"id_ground", "id_float", "se0conn", "vbusvld",
-				"sessvld", "sessend", "se1", "dm", "dp";
-			mode-gpios = <&gpio2 28 GPIO_ACTIVE_HIGH
-				      &gpio1 0 GPIO_ACTIVE_HIGH>;
+				"id_ground", "id_float", "se0conn",
+				"vbusvld", "sessvld", "sessend",
+				"se1", "dm", "dp";
+			mode-gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>,
+				     <&gpio1 0 GPIO_ACTIVE_HIGH>;
 			io-channels = <&cpcap_adc 2>, <&cpcap_adc 7>;
 			io-channel-names = "vbus", "id";
 			vusb-supply = <&vusb>;
-- 
2.30.1


  reply	other threads:[~2021-03-12 15:45 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12 15:43 [PATCH 00/38] Convert power-supply DT bindings to YAML Sebastian Reichel
2021-03-12 15:43 ` Sebastian Reichel [this message]
2021-03-12 15:43 ` [PATCH 02/38] dt-bindings: power: supply: cpcap-battery: Convert to DT schema format Sebastian Reichel
2021-03-12 15:43 ` [PATCH 03/38] dt-bindings: power: supply: cpcap-charger: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 04/38] dt-bindings: power: supply: bq25890: " Sebastian Reichel
2021-03-15 18:21   ` Rob Herring
2021-03-16 16:46     ` Sebastian Reichel
2021-03-16 17:50       ` Rob Herring
2021-03-12 15:43 ` [PATCH 05/38] dt-bindings: power: supply: bq24257: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 06/38] dt-bindings: power: supply: bq24190: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 07/38] dt-bindings: power: supply: bq2415x: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 08/38] dt-bindings: power: supply: bq24735: " Sebastian Reichel
2021-03-15 18:24   ` Rob Herring
2021-03-16 16:22     ` Sebastian Reichel
2021-03-16 17:45       ` Rob Herring
2021-03-12 15:43 ` [PATCH 09/38] dt-bindings: power: supply: isp1704: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 10/38] dt-bindings: power: supply: sbs-charger: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 11/38] dt-bindings: power: supply: sbs-manager: " Sebastian Reichel
2021-03-15 18:27   ` Rob Herring
2021-03-12 15:43 ` [PATCH 12/38] dt-bindings: power: supply: ds2760: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 13/38] dt-bindings: power: supply: sc27xx-fg: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 14/38] dt-bindings: power: supply: sc2731-charger: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 15/38] dt-bindings: power: supply: tps65090: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 16/38] dt-bindings: power: supply: tps65217: " Sebastian Reichel
2021-03-15 18:33   ` Rob Herring
2021-03-16 16:20     ` Sebastian Reichel
2021-03-16 17:52       ` Rob Herring
2021-03-12 15:43 ` [PATCH 17/38] dt-bindings: power: supply: twl4030: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 18/38] dt-bindings: power: supply: n900-battery: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 19/38] dt-bindings: power: supply: lego-ev3-battery: " Sebastian Reichel
2021-03-12 16:04   ` David Lechner
2021-03-12 15:43 ` [PATCH 20/38] dt-bindings: power: supply: max17040: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 21/38] dt-bindings: power: supply: max14656: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 22/38] dt-bindings: power: supply: max17042: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 23/38] dt-bindings: power: supply: max8903: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 24/38] dt-bindings: power: supply: ucs1002: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 25/38] dt-bindings: power: supply: pm8941-charger: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 26/38] dt-bindings: power: supply: pm8941-coincell: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 27/38] dt-bindings: power: supply: act8945a: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 28/38] dt-bindings: power: supply: axp20x: " Sebastian Reichel
2021-03-24  3:02   ` Chen-Yu Tsai
2021-03-12 15:43 ` [PATCH 29/38] dt-bindings: power: supply: da9150: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 30/38] dt-bindings: power: supply: lp8727: " Sebastian Reichel
2021-03-15 18:37   ` Rob Herring
2021-03-12 15:43 ` [PATCH 31/38] dt-bindings: power: supply: lt3651: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 32/38] dt-bindings: power: supply: ltc294x: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 33/38] dt-bindings: power: supply: rt9455: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 34/38] dt-bindings: power: supply: olpc-battery: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 35/38] dt-bindings: power: supply: ab8500: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 36/38] dt-bindings: power: supply: sbs-battery: Fix dtbs_check Sebastian Reichel
2021-03-12 15:43 ` [PATCH 37/38] dt-bindings: power: supply: Fix remaining battery.txt links Sebastian Reichel
2021-03-12 15:43 ` [PATCH 38/38] dt-bindings: power: supply: Drop power_supply.txt Sebastian Reichel
2021-03-15 19:44 ` [PATCH 00/38] Convert power-supply DT bindings to YAML Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210312154357.1561730-2-sebastian.reichel@collabora.com \
    --to=sebastian.reichel@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®