From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Zi Yan <ziy@nvidia.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>, John Hubbard <jhubbard@nvidia.com>,
Sandipan Das <sandipan@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Yang Shi <shy828301@gmail.com>,
Mika Penttila <mika.penttila@nextfour.com>
Subject: Re: [PATCH v3] mm: huge_memory: a new debugfs interface for splitting THP tests.
Date: Mon, 15 Mar 2021 15:07:48 +0300 [thread overview]
Message-ID: <20210315120748.nuw5vk6grmfacact@box> (raw)
In-Reply-To: <20210312005712.116888-1-zi.yan@sent.com>
On Thu, Mar 11, 2021 at 07:57:12PM -0500, Zi Yan wrote:
> From: Zi Yan <ziy@nvidia.com>
>
> We do not have a direct user interface of splitting the compound page
> backing a THP
But we do. You expand it.
> and there is no need unless we want to expose the THP
> implementation details to users. Make <debugfs>/split_huge_pages accept
> a new command to do that.
>
> By writing "<pid>,<vaddr_start>,<vaddr_end>" to
> <debugfs>/split_huge_pages, THPs within the given virtual address range
> from the process with the given pid are split. It is used to test
> split_huge_page function. In addition, a selftest program is added to
> tools/testing/selftests/vm to utilize the interface by splitting
> PMD THPs and PTE-mapped THPs.
>
Okay, makes sense.
But it doesn't cover non-mapped THPs. tmpfs may have file backed by THP
that mapped nowhere. Do we want to cover this case too?
Maybe have PID:<pid>,<vaddr_start>,<vaddr_end> and
FILE:<path>,<off_start>,<off_end> ?
--
Kirill A. Shutemov
next prev parent reply other threads:[~2021-03-15 12:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 0:57 Zi Yan
2021-03-15 12:07 ` Kirill A. Shutemov [this message]
2021-03-15 18:37 ` Zi Yan
2021-03-15 19:13 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315120748.nuw5vk6grmfacact@box \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mika.penttila@nextfour.com \
--cc=sandipan@linux.ibm.com \
--cc=shuah@kernel.org \
--cc=shy828301@gmail.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome