From: Alex Elder <elder@linaro.org>
To: subashab@codeaurora.org, stranche@codeaurora.org,
davem@davemloft.net, kuba@kernel.org
Cc: sharathv@codeaurora.org, bjorn.andersson@linaro.org,
evgreen@chromium.org, cpratapa@codeaurora.org,
David.Laight@ACULAB.COM, olteanv@gmail.com, elder@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next v4 0/6] net: qualcomm: rmnet: stop using C bit-fields
Date: Mon, 15 Mar 2021 08:34:49 -0500 [thread overview]
Message-ID: <20210315133455.1576188-1-elder@linaro.org> (raw)
The main reason for version 4 of this series is that a bug was
introduced in version 3, and that is fixed.
But a nice note from Vladimir Oltean got me thinking about the
necessity of using accessors defined in <linux/bitfield.h>, and I
concluded there was no need. So this version simplifies things
further, using bitwise AND and OR operators (rather than, e.g.,
u8_get_bits()) to access all values encoded in bit fields.
This version has been tested using IPv4 with checksum offload
enabled and disabled. Traffic over the link included ICMP (ping),
UDP (iperf), and TCP (wget).
Version 3 of this series used BIT() rather than GENMASK() to define
single-bit masks, and bitwise AND operators to access them.
Version 2 fixed bugs in the way the value written into the header
was computed in version 1.
The series was first posted here:
https://lore.kernel.org/netdev/20210304223431.15045-1-elder@linaro.org/
-Alex
Alex Elder (6):
net: qualcomm: rmnet: mark trailer field endianness
net: qualcomm: rmnet: simplify some byte order logic
net: qualcomm: rmnet: kill RMNET_MAP_GET_*() accessor macros
net: qualcomm: rmnet: use masks instead of C bit-fields
net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum trailer
net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum header
.../ethernet/qualcomm/rmnet/rmnet_handlers.c | 10 +--
.../net/ethernet/qualcomm/rmnet/rmnet_map.h | 12 ----
.../qualcomm/rmnet/rmnet_map_command.c | 11 +++-
.../ethernet/qualcomm/rmnet/rmnet_map_data.c | 60 ++++++++---------
include/linux/if_rmnet.h | 65 +++++++++----------
5 files changed, 69 insertions(+), 89 deletions(-)
--
2.27.0
next reply other threads:[~2021-03-15 13:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 13:34 Alex Elder [this message]
2021-03-15 13:34 ` [PATCH net-next v4 1/6] net: qualcomm: rmnet: mark trailer field endianness Alex Elder
2021-03-15 13:34 ` [PATCH net-next v4 2/6] net: qualcomm: rmnet: simplify some byte order logic Alex Elder
2021-03-15 16:02 ` Alexander Duyck
2021-03-15 17:12 ` Alex Elder
2021-03-15 13:34 ` [PATCH net-next v4 3/6] net: qualcomm: rmnet: kill RMNET_MAP_GET_*() accessor macros Alex Elder
2021-03-15 13:34 ` [PATCH net-next v4 4/6] net: qualcomm: rmnet: use masks instead of C bit-fields Alex Elder
2021-03-15 13:34 ` [PATCH net-next v4 5/6] net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum trailer Alex Elder
2021-03-15 13:34 ` [PATCH net-next v4 6/6] net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum header Alex Elder
2021-03-15 16:12 ` [PATCH net-next v4 0/6] net: qualcomm: rmnet: stop using C bit-fields Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315133455.1576188-1-elder@linaro.org \
--to=elder@linaro.org \
--cc=David.Laight@ACULAB.COM \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=sharathv@codeaurora.org \
--cc=stranche@codeaurora.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome