From: David Miller <davem@davemloft.net>
To: linyunsheng@huawei.com
Cc: kuba@kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
jiri@resnulli.us, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxarm@openeuler.org
Subject: Re: [PATCH net-next] net: sched: remove unnecessay lock protection for skb_bad_txq/gso_skb
Date: Tue, 16 Mar 2021 14:45:33 -0700 (PDT) [thread overview]
Message-ID: <20210316.144533.1015318495899101097.davem@davemloft.net> (raw)
In-Reply-To: <1fea8225-69b0-5a73-0e9d-f5bfdecdc840@huawei.com>
From: Yunsheng Lin <linyunsheng@huawei.com>
Date: Tue, 16 Mar 2021 10:40:56 +0800
> On 2021/3/16 7:41, David Miller wrote:
>> From: Yunsheng Lin <linyunsheng@huawei.com>
>
> At least for the fast path, taking two locks for lockless qdisc hurts
> performance when handling requeued skb, especially if the lockless
> qdisc supports TCQ_F_CAN_BYPASS.
The bad txq and gro skb cases are not "fast path", sorry
next prev parent reply other threads:[~2021-03-16 21:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 9:30 Yunsheng Lin
2021-03-15 23:41 ` David Miller
2021-03-16 2:40 ` Yunsheng Lin
2021-03-16 21:45 ` David Miller [this message]
2021-03-17 0:45 ` Yunsheng Lin
2021-03-16 18:43 ` Cong Wang
2021-03-17 0:50 ` Yunsheng Lin
2021-03-16 18:41 ` Cong Wang
2021-03-17 1:01 ` Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316.144533.1015318495899101097.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®