From: He Ying <heying24@huawei.com>
To: <peterz@infradead.org>, <mingo@kernel.org>, <frederic@kernel.org>,
<paulmck@kernel.org>, <christophe.leroy@csgroup.eu>,
<clg@kaod.org>, <qais.yousef@arm.com>
Cc: <johnny.chenyi@huawei.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] smp: kernel/panic.c - silence warnings
Date: Tue, 16 Mar 2021 00:08:19 -0400 [thread overview]
Message-ID: <20210316040819.29085-1-heying24@huawei.com> (raw)
We found these warnings in kernel/panic.c by using sparse tool:
warning: symbol 'panic_smp_self_stop' was not declared.
warning: symbol 'nmi_panic_self_stop' was not declared.
warning: symbol 'crash_smp_send_stop' was not declared.
To avoid them, add declarations for these three functions in
include/linux/smp.h.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: He Ying <heying24@huawei.com>
---
include/linux/smp.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/include/linux/smp.h b/include/linux/smp.h
index 70c6f6284dcf..861a253cc179 100644
--- a/include/linux/smp.h
+++ b/include/linux/smp.h
@@ -50,6 +50,14 @@ extern unsigned int total_cpus;
int smp_call_function_single(int cpuid, smp_call_func_t func, void *info,
int wait);
+/*
+ * Cpus stopping functions in panic. All have default weak definations.
+ * Architecure dependent code may override them.
+ */
+void panic_smp_self_stop(void);
+void nmi_panic_self_stop(struct pt_regs *regs);
+void crash_smp_send_stop(void);
+
/*
* Call a function on all processors
*/
--
2.17.1
next reply other threads:[~2021-03-16 4:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 4:08 He Ying [this message]
2021-03-16 5:15 ` Randy Dunlap
2021-03-16 6:35 ` heying (H)
2021-03-16 6:58 ` Christophe Leroy
2021-03-16 7:13 ` heying (H)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316040819.29085-1-heying24@huawei.com \
--to=heying24@huawei.com \
--cc=christophe.leroy@csgroup.eu \
--cc=clg@kaod.org \
--cc=frederic@kernel.org \
--cc=johnny.chenyi@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®