From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD2C1C4332B for ; Thu, 18 Mar 2021 15:17:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D55264F65 for ; Thu, 18 Mar 2021 15:17:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231703AbhCRPQ4 (ORCPT ); Thu, 18 Mar 2021 11:16:56 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:41979 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230282AbhCRPQ2 (ORCPT ); Thu, 18 Mar 2021 11:16:28 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lMuNv-0001rJ-15; Thu, 18 Mar 2021 15:16:27 +0000 From: Colin King To: Jens Axboe , Dan Schatzberg , linux-block@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] loop: Fix missing max_active argument in alloc_workqueue call Date: Thu, 18 Mar 2021 15:16:26 +0000 Message-Id: <20210318151626.17442-1-colin.king@canonical.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The 3rd argument to alloc_workqueue should be the max_active count, however currently it is the lo->lo_number that is intended for the loop%d number. Fix this by adding in the missing max_active count. Addresses-Coverity: ("Missing argument to printf") Fixes: 08ad7f822739 ("loop: Use worker per cgroup instead of kworker") Signed-off-by: Colin Ian King --- drivers/block/loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index f2f9e4127847..ee2a6c1bc093 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -1192,7 +1192,7 @@ static int loop_configure(struct loop_device *lo, fmode_t mode, lo->workqueue = alloc_workqueue("loop%d", WQ_UNBOUND | WQ_FREEZABLE | WQ_MEM_RECLAIM, - lo->lo_number); + 1, lo->lo_number); if (!lo->workqueue) { error = -ENOMEM; goto out_unlock; -- 2.30.2