From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6D80C433E0 for ; Fri, 19 Mar 2021 10:38:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 627F064F6A for ; Fri, 19 Mar 2021 10:38:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229751AbhCSKhd (ORCPT ); Fri, 19 Mar 2021 06:37:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:37424 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229844AbhCSKhC (ORCPT ); Fri, 19 Mar 2021 06:37:02 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7D5C4ACC6; Fri, 19 Mar 2021 10:37:01 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 4B6301F2B5B; Fri, 19 Mar 2021 11:37:01 +0100 (CET) Date: Fri, 19 Mar 2021 11:37:01 +0100 From: Jan Kara To: Alexander Lochmann Cc: jack@suse.cz, Horst Schirmeier , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Updated locking documentation for journal_head Message-ID: <20210319103701.GC4910@quack2.suse.cz> References: <9864e9792b56bce87b016582a8759890079f7766> <20210319091819.113326-1-alexander.lochmann@tu-dortmund.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210319091819.113326-1-alexander.lochmann@tu-dortmund.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 19-03-21 10:18:17, Alexander Lochmann wrote: > LockDoc's results show that t_list_lock has been > replaced by j_list_lock for b_next_transaction, > b_tnext, and b_tprev. > We, therefore, updated the documentation > accordingly. > > Signed-off-by: Alexander Lochmann > Signed-off-by: Horst Schirmeier Yeah, I think that was a typo since the beginning. Thanks for the fix. Feel free to add: Reviewed-by: Jan Kara Honza > --- > include/linux/journal-head.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/journal-head.h b/include/linux/journal-head.h > index 75bc56109031..d68ae72784eb 100644 > --- a/include/linux/journal-head.h > +++ b/include/linux/journal-head.h > @@ -80,13 +80,13 @@ struct journal_head { > * Pointer to the running compound transaction which is currently > * modifying the buffer's metadata, if there was already a transaction > * committing it when the new transaction touched it. > - * [t_list_lock] [b_state_lock] > + * [j_list_lock] [b_state_lock] > */ > transaction_t *b_next_transaction; > > /* > * Doubly-linked list of buffers on a transaction's data, metadata or > - * forget queue. [t_list_lock] [b_state_lock] > + * forget queue. [j_list_lock] [b_state_lock] > */ > struct journal_head *b_tnext, *b_tprev; > > -- > 2.20.1 > -- Jan Kara SUSE Labs, CR