From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A74BC433DB for ; Fri, 19 Mar 2021 13:23:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DC4A64EC0 for ; Fri, 19 Mar 2021 13:23:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230014AbhCSNXK (ORCPT ); Fri, 19 Mar 2021 09:23:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229821AbhCSNWq (ORCPT ); Fri, 19 Mar 2021 09:22:46 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 911E5C06174A; Fri, 19 Mar 2021 06:22:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2KS9BVm2N7BFC51UrW+/8IGJ0MRGc1xx7mmgTk+g7Ck=; b=n3IUUh3aXo0JWD2wwOFW2ef/JX 7he8eoKNWqSKvmwXduCO9vGrHKcg6SnwHcWTHJz45edEUqaq/hk8q727hY2kq9y+jTFam61GWQrhG fmfHy5usrFG5GE9yqN8jAw8ePQ6miFu5YdhdXtNUwb1GYKYsbxiX8h/xOTD7qgAT3ZAhYH9G+vjhe L8g1fXJrm4rd3vUE4Ho2bTvg3vU4DixQcHhX1a/yYR/xYepeqAIlRcNguEJRERXQcB9jfShsBIsie liOlvmtwm1KYswYxVtFGkUXreaphaYAvVDtIZ/CKukhYqlB5DpNYwgkol/zsXmaXvINPWvHH8E2V3 H2OmBNDA==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lNF4L-004Rbo-Ez; Fri, 19 Mar 2021 13:21:42 +0000 Date: Fri, 19 Mar 2021 13:21:37 +0000 From: Matthew Wilcox To: Johannes Weiner Cc: Andrew Morton , Michal Hocko , Hugh Dickins , Zhou Guanghui , Zi Yan , Shakeel Butt , Roman Gushchin , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH] mm: page_alloc: fix memcg accounting leak in speculative cache lookup Message-ID: <20210319132137.GZ3420@casper.infradead.org> References: <20210319071547.60973-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210319071547.60973-1-hannes@cmpxchg.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 19, 2021 at 03:15:47AM -0400, Johannes Weiner wrote: > When the freeing of a higher-order page block (non-compound) races > with a speculative page cache lookup, __free_pages() needs to leave > the first order-0 page in the chunk to the lookup but free the buddy > pages that the lookup doesn't know about separately. Thanks.