From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC5ACC433E9 for ; Fri, 19 Mar 2021 13:40:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C47B964F1C for ; Fri, 19 Mar 2021 13:40:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229634AbhCSNjt (ORCPT ); Fri, 19 Mar 2021 09:39:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229821AbhCSNjp (ORCPT ); Fri, 19 Mar 2021 09:39:45 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84C31C06174A for ; Fri, 19 Mar 2021 06:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Zz9OTExqWnVyVHLTeY/MLahbbs3q6nG+4sXDvkfDjns=; b=vvEhNtibtwpUxVKyUI6OVRz4/A Qp6liY6gXAiGZ6RXI8w1adnCO4ehL0uPGPiOXmM2YUIwtBkQ0b9MTUTWpRCWH0uwIAm9EXq7cvy4r mFxMEk2c6slQ6OMzVB+MXjnNVRGSMn6BFkKrYGsV0SDAZ2lL5rV3jETakxml9M8sqsuAjVdmA3Ti8 c+h7yJWkjqvnSIPcXt4ImJBOY2tfwjKcwDzX5EACj7kul3zkyWG1CAleFGisTx6qiAyY1DtRSTRfl RZV0Egowij7o0BeE27Gc938O0GEDrtNZ7g5MpXzWHdbeRQKSF51FK0pUD1xK5R1KzSQDrcIpM2ybr GSwGrIgw==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lNFLM-004ShW-67; Fri, 19 Mar 2021 13:39:16 +0000 Date: Fri, 19 Mar 2021 13:39:12 +0000 From: Christoph Hellwig To: Robin Murphy Cc: joro@8bytes.org, iommu@lists.linux-foundation.org, will@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] iommu: Statically set module owner Message-ID: <20210319133912.GA1063154@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 19, 2021 at 12:52:01PM +0000, Robin Murphy wrote: > It happens that the 3 drivers which first supported being modular are > also ones which play games with their pgsize_bitmap, so have non-const > iommu_ops where dynamically setting the owner manages to work out OK. > However, it's less than ideal to force that upon all drivers which want > to be modular - like the new sprd-iommu driver which now has a potential > bug in that regard - so let's just statically set the module owner and > let ops remain const wherever possible. > > Signed-off-by: Robin Murphy > --- > > This is something I hadn't got round to sending earlier, so now rebased > onto iommu/next to accommodate the new driver :) Ah, nice. That __iommu_device_set_ops dance always confused me. Reviewed-by: Christoph Hellwig