From: Jonathan Cameron <jic23@kernel.org>
To: Guoqing chi <chi962464zy@163.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
lars@metafoo.de, Michael.Hennerich@analog.com,
marcelo.schmitt1@gmail.com, pmeerw@pmeerw.net,
chiguoqing@yulong.com
Subject: Re: [PATCH] iio: adc: ad7292: Modify the bool initialization assignment
Date: Sat, 20 Mar 2021 15:07:30 +0000 [thread overview]
Message-ID: <20210320150730.67635739@jic23-huawei> (raw)
In-Reply-To: <20210319062706.5135-1-chi962464zy@163.com>
On Fri, 19 Mar 2021 14:27:06 +0800
Guoqing chi <chi962464zy@163.com> wrote:
> From: Guoqing Chi <chiguoqing@yulong.com>
>
> A bool initializer is best assigned to false rather than 0.
>
> Signed-off-by: Guoqing Chi <chiguoqing@yulong.com>
Hi
This one is a bit marginal as counting as noise rather that a useful
change in an existing driver. I'll take it this time, but I'm not
keen to see lots of these unless they form part of larger sets cleaning
up the drivers in question.
Applied to the togreg branch of iio.git and pushed out as testing for
the auto builders to ignore it.
thanks,
Jonathan
> ---
> drivers/iio/adc/ad7292.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7292.c b/drivers/iio/adc/ad7292.c
> index 70e33dd1c9f7..3271a31afde1 100644
> --- a/drivers/iio/adc/ad7292.c
> +++ b/drivers/iio/adc/ad7292.c
> @@ -260,7 +260,7 @@ static int ad7292_probe(struct spi_device *spi)
> struct ad7292_state *st;
> struct iio_dev *indio_dev;
> struct device_node *child;
> - bool diff_channels = 0;
> + bool diff_channels = false;
> int ret;
>
> indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
next prev parent reply other threads:[~2021-03-20 15:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 6:27 Guoqing chi
2021-03-20 14:21 ` Marcelo Schmitt
2021-03-20 15:07 ` Jonathan Cameron [this message]
2021-03-22 1:42 ` Guoqing Chi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210320150730.67635739@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=chi962464zy@163.com \
--cc=chiguoqing@yulong.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®