mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julian Braha <julianbraha@gmail.com>
To: broonie@kernel.org
Cc: linux-kernel@vger.kernel.org, fazilyildiran@gmail.com
Subject: [PATCH] sound: soc: sh: fix Kconfig dependency on DMADEVICES
Date: Sun, 21 Mar 2021 19:19:19 -0400	[thread overview]
Message-ID: <20210321231919.262142-1-julianbraha@gmail.com> (raw)

When SND_SIU_MIGOR is enabled, and DMADEVICES is disabled,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for SND_SOC_SH4_SIU
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && (SUPERH [=y] || ARCH_RENESAS || COMPILE_TEST [=n]) && ARCH_SHMOBILE [=y] && HAVE_CLK [=y] && DMADEVICES [=n]
  Selected by [y]:
  - SND_SIU_MIGOR [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && (SUPERH [=y] || ARCH_RENESAS || COMPILE_TEST [=n]) && SH_MIGOR [=y] && I2C [=y]

This is because SND_SIU_MIGOR selects SND_SOC_SH4_SIU
without selecting or depending on DMADEVICES,
despite SND_SOC_SH4_SIU depending on DMADEVICES.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 sound/soc/sh/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sh/Kconfig b/sound/soc/sh/Kconfig
index 346c806ba390..503ee235e46d 100644
--- a/sound/soc/sh/Kconfig
+++ b/sound/soc/sh/Kconfig
@@ -60,7 +60,7 @@ config SND_SH7760_AC97
 
 config SND_SIU_MIGOR
 	tristate "SIU sound support on Migo-R"
-	depends on SH_MIGOR && I2C
+	depends on SH_MIGOR && I2C && DMADEVICES
 	select SND_SOC_SH4_SIU
 	select SND_SOC_WM8978
 	help
-- 
2.25.1


                 reply	other threads:[~2021-03-21 23:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210321231919.262142-1-julianbraha@gmail.com \
    --to=julianbraha@gmail.com \
    --cc=broonie@kernel.org \
    --cc=fazilyildiran@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®