From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82DF9C433E4 for ; Mon, 22 Mar 2021 11:57:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65180619A1 for ; Mon, 22 Mar 2021 11:57:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230289AbhCVL4b (ORCPT ); Mon, 22 Mar 2021 07:56:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:45652 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230242AbhCVL4H (ORCPT ); Mon, 22 Mar 2021 07:56:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5740D61993; Mon, 22 Mar 2021 11:56:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616414166; bh=v02+Q4Y/k5N5zyuH15US/OzUofNlFXTHJrTv94Wy354=; h=From:To:Cc:Subject:Date:From; b=HhEl8R7wxUe6N6+JjBywxIcTizWiUXEt1SOxVHC7RILixuJUgrUWRN3OS9QOhtXP+ BLNmFhlvHGPRlqU0k3AqRRg/1Zu8AffkAp+cQ9PCpvJzlOr2W6xbVUChwACDnk9/5W 8i0kkZZ5zSj4MCtxokKGXJVYQ7EaFMzwuJb9TDPCD1peJHsxwKhkQg5mEEil73yhfP hwnJ4i3TMEv7oo5Mh4k0jfVMAs5bDN1yxe33n4jACq2hCQ6yEwdx8TVjYXRKwyKUjn sbA2WUThcixS0dGT2U2hKNY1QJmVg7eJ3ohTLSzvHGqbXYVU8UQBhu/xdvFSU4mrc5 K1ppWa6mTt7Eg== From: Arnd Bergmann To: Benson Leung , Enric Balletbo i Serra , Nathan Chancellor , Nick Desaulniers , Prashant Malani , Heikki Krogerus Cc: Arnd Bergmann , Guenter Roeck , Greg Kroah-Hartman , Azhar Shaikh , Utkarsh Patel , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: [PATCH] platform/chrome: cros_ec_typec: fix clang -Wformat warning Date: Mon, 22 Mar 2021 12:55:55 +0100 Message-Id: <20210322115602.4003221-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Clang warns about using the %h format modifier to truncate an integer: drivers/platform/chrome/cros_ec_typec.c:1031:3: error: format specifies type 'unsigned char' but the argument has type 'unsigned int' [-Werror,-Wformat] typec->pd_ctrl_ver); ^~~~~~~~~~~~~~~~~~ include/linux/dev_printk.h:131:47: note: expanded from macro 'dev_dbg' dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ ~~~ ^~~~~~~~~~~ Use an explicit bit mask to limit the number to its lower eight bits instead. Fixes: ad7c0510c99e ("platform/chrome: cros_ec_typec: Update port info from EC") Signed-off-by: Arnd Bergmann --- drivers/platform/chrome/cros_ec_typec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index 0811562deecc..f07b7e946560 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -1027,8 +1027,8 @@ static int cros_typec_get_cmd_version(struct cros_typec_data *typec) else typec->pd_ctrl_ver = 0; - dev_dbg(typec->dev, "PD Control has version mask 0x%hhx\n", - typec->pd_ctrl_ver); + dev_dbg(typec->dev, "PD Control has version mask 0x%02x\n", + typec->pd_ctrl_ver & 0xff); return 0; } -- 2.29.2